-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add missing i386 and x86_64h targets to tbd #439
Conversation
I believe that there's a small chance that if you generate from iOS it'll have symbols that don't exist on macOS /intel |
That's true. Do we want to detect the platform based on the binary and generate the targets based on that? The downside of this is that using something like a DSC, it would only define the targets for that specific architecture. |
Also look at #409 |
Another patch that I was planning to submit is to make the XCFramework support all platforms ( But that only makes sense if our goal is to produce a generic XCFramework, with no guarantee that all symbols will be available at runtime. This may be a problem, but at the same time is supper handy because you don't have to get binaries for all architectures and platforms, generate XCFWs for each of them, and finally merge them into a single XCFW. |
Will move the discussion there |
I believe we can get the ARCH and "platform" from the DSC header so that might be good enough to determine what to include in the I think older DSCs might not have as much metadata about the platform so that'd be an edge case where maybe we'd just add them all etc? |
I believe we can close this PR based on the commit mentioned. |
This patch adds the missing
i386-macos
,i386-maccatalyst
,x86_64h-macos
, andx86_64h-maccatalyst
targets to TBD generation.