Skip to content

create default app_service based on first service #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

create default app_service based on first service #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2df4ed2
grabs the service name from the first service in options._app.info, b…
gilzow Nov 19, 2021
a46444c
Adds an extra check to make sure the service name we've selected exis…
gilzow Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions services/blackfire/builder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@ module.exports = {
parent: '_service',
builder: (parent, config) => class LandoBlackfire extends parent {
constructor(id, options = {}) {
// set a default app_service using the first service in options._app.info
if (options._app.hasOwnProperty('info') && options._app.info instanceof Array) {
const closestService = _.first(options._app.info);
//now double-check to make sure the service object exists in config services.
if(options._app.config.services.hasOwnProperty(closestService.service)) {
config.app_service = closestService.service;
}
Comment on lines +27 to +31
Copy link
Contributor

@lolautruche lolautruche Nov 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WS alignment 😉

Suggested change
const closestService = _.first(options._app.info);
//now double-check to make sure the service object exists in config services.
if(options._app.config.services.hasOwnProperty(closestService.service)) {
config.app_service = closestService.service;
}
const closestService = _.first(options._app.info);
// now double-check to make sure the service object exists in config services.
if(options._app.config.services.hasOwnProperty(closestService.service)) {
config.app_service = closestService.service;
}

Copy link
Contributor Author

@gilzow gilzow Nov 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad. Was using a different IDE from my preferred. Do we have a .editorconfig file we use to ensure proper spacing?

}
options = _.merge({}, config, options);

// Ensure that the credentials are correctly set.
Expand Down