Open
Conversation
Collaborator
|
I haven't looked at the code here yet, but could we make sure the support is for any type of file? We could then have a manager method to grab images (capture mimetype on upload? allow user to choose filetype?). This would allow for owners to upload files that aren't images like config files and calibration templates. These extra files could then be included in a sidebar on the tool page. |
Contributor
Author
|
@jsatt Sure, I can probably do some multi-table stuff with the File/Photo model. Currently, the interface for uploading images is drag and drop into the markdown editor. Should we add another attachment area instead for the other files? |
Collaborator
|
I'm not sure that we initially need multi-table for it initially, I think
just a way to store generic files, some of them being images, is probably
fine, but if you see a use case, go for it.
Yeah probably a separate drop area is fine. I guess it depends on the UX
you're looking for. In my mind it was just something fairly simply, where
you just drop all files in one place, then images just appeared in a
carousel at the top of the page and other files in a sidebar (like
thingiverse). But I think integrating into the markdown editor is fine too.
Is it possible to have previews of all the images that are already attached
to the tool, regardless of which upload drop was used, and drop them into
the markdown without another upload? Maybe also if you drop a non-image
file it injects the markdown for a link to the file? I personally don't
think it'd be a huge inconvenience if you had one drop-zone then dragged
them into the markdown after the upload.
Anyway, there's lots of possibilities. I'd say go with whatever works.
…On Thu, Mar 14, 2019 at 10:14 AM Patrick Forringer ***@***.***> wrote:
@jsatt <https://github.com/jsatt> Sure, I can probably do some
multi-table stuff with the File/Photo model. Currently, the interface for
uploading images is drag and drop into the markdown editor. Should we add
another attachment area instead for the other files?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#122 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAea_5qkGtEWZjRqi_aKIL41aL3O3yUrks5vWmc2gaJpZM4bqKMU>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes #120 can be merged first or together with this PR
Relies on: neutronX/django-markdownx/pull/153 being merged. Or we'll have to use a fork in the pyproject.toml