Allow configuring vulkan renderer max descriptor sets per frame #3461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm it works for me as well, tested on the latest FFNx canary release v1.22.0.98 on Windows 11 x64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows configuring the vulkan renderer max descriptor sets per frame in BGFX.
This solves #2850 for at least two people (me and @julianxhokaxhiu, who had similar issues related to
VK_ERROR_OUT_OF_POOL_MEMORY).I believe this feature should be harmless as it's just exposing the original value to be overriden when compiling.
For testing, a large vulkan scene should no longer trigger the assert if we increase value of the new config option.
Thank you for your time!