Another fix for crashing with VK_DEVICE_LOST #3404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll take a look at it tomorrow most likely. You change looks plausible. It's been a while since looked into this. Could you break down why this change would be correct? |
|
The same reason you put this comment in. |
|
I took some time to think about it, and it looks 100% reasonable that that would also be required. @bkaradzic I think this can be merged. I haven't tested anything, but the change looks correct. |
mcourteaux
approved these changes
Jan 31, 2025
jazzbre
pushed a commit
to jazzbre/bgfx
that referenced
this pull request
Mar 17, 2025
bkaradzic
added a commit
that referenced
this pull request
Jul 11, 2025
* Updated README (with World Of Goo 2). * Updated README (with World Of Goo 2). * Updated cgltf. * Updated meshoptimizer. * Updated ImGui. * Updated glslang. * Updated spirv-headers. * Updated spirv-tools. * Updated spirv-cross. * Updated Vulkan headers. * Fix a crash in renderer_d3d12.cpp (#3349) If querying the debug1 interface fails, don't attempt to release it. * D bindings: Fix a casing error (#3350) * Fix error in dynamic version of D bindings Dazed and confused but trying to continue * Fix dispatch_indirect still using uint16_t in bgfx.idl * D bindings: Mark enum conv. functions `nothrow @nogc pure @safe` * D bindings: Fix a casing error * fix typo (scrach -> scratch) (#3353) * Imgui: Add ability to link external STB libs. * Revert "Updated spirv-tools." This reverts commit 7cda7c9. * Rebuilt spir-v shaders. * Properly support Wayland under EGL and Vulkan. (#3358) * Improve NX Vulkan support. (#3357) This change was developed using publicly available information found in Vulkan headers and official documentation. No proprietary NX resources were used. Co-authored-by: Бранимир Караџић <[email protected]> * Dynamically load libwayland-egl.so.1 when dealing with Wayland to remove dependencies at program startup. (#3359) * Cleanup. * Cleanup. * Support both X11 and Wayland in the same build. (#3360) * Support both X11 and Wayland in the same build. - Works for both Vulkan and OpenGL. - Remove --with-wayland from genie options. - Vulkan loads all three extensions for surface creation instead of only one. - Add width and height parameter to GlContext::createSwapChain(), which is needed for EGL to create a SwapChain with the given window size. - Dirty-fix the example-22-windows to recreate the FrameBuffer by first destroying and then recreating to make sure the window is released of its swapchain. - Fix dbgText glitch in example-22-windows. - Remove old X11-related dependencies for GLFW3. * Formatting. * Build documentation improvements (#3362) * Some documentation improvements: extra info on using GENie. * Some grammer. * Bump minimum GLFW version to 3.4. * Insert vkDeviceWaitIdle to prevent VK_DEVICE_LOST. (#3363) * Cleanup. * Updated version. * Updated meshoptimizer. * Updated glslang. * Updated spirv-headers. * Updated spirv-tools. * Updated spirv-cross. * Updated Vulkan headers. * Cleanup. * Updated ImGui. * shaderc: Fixed build. * wasm: Fixed build. * Cleanup. * Fixed clang-debug target trying to build with gcc. (#3368) Co-authored-by: -- <--> * Fix compiling entry_noop (#3369) * Updated GHA containers. * Use DXGI_SWAP_CHAIN_DESC1 if available for additional scaling options. (#3370) * Fix: Fix Uniform buffer doing too many iterations when updating renderer uniforms (#3372) * Fixed IDL, added C++ IDL template. * Updated version. * Cleanup. * Silent clang warnings. * Updated README.md, fix typo(s) (#3376) * Disable mingw-clang due broken winnt.h header. * Fix various typos (#3377) Found via `codespell -q 3 -S "./3rdparty,*.ttf,*.bin,./examples/common/imgui,./examples/common/font" -L attribut,ba,clude,conly,constan,espace,hashin,indext,inout,lod,nclude,retur,ser,sroll,struc,te,truct,unknwn,usin,utput,varyin` * Assert on OOM. * Fix Vulkan swapchain invalidation issue. (#3379) * Fix Vulkan swapchain invalidation issue. * Always clamp render pass to frame buffer size. * Fix formatting. * Cleanup. * shaderc: Show correct error line. * Cleanup. * Format files to remove trailing spaces (#3384) * Updated bindings. * Updated docs. * Cleanup. * Cleanup. * Fixed MSVC warnings. * Removing alloca compat include. * Fixed build. * Fixed warning. * Updated ImGui. * Updated cgltf. * Updated meshoptimizer. * Updated glslang. * Updated spirv-headers. * Updated spirv-tools. * Updated spirv-cross. * Updated version. * Revert "Fix: Fix Uniform buffer doing too many iterations when updating rende…" (#3391) This reverts commit 4bc6529. * Happy New Year! * Update README.md (#3394) Added Off The Road 2 * Fix #3344 (#3399) * Fix UniformBuffer UB regarding UniformType::Enum with extra bits. (#3398) * Fix only one frame rendered in mobile opengles with intermediate frame buffer (#3405) * Another fix for crashing with VK_DEVICE_LOST (#3404) * Fix wasm tinystl compile error (#3406) * utilize bx::strLen instead of C function * utilize bx::strCopy instead of C function * Updated ImGui. * Updated meshoptimizer. * Updated cgltf. * Updated glslang. * Updated spirv-headers. * Updated spirv-tools. * Updated spirv-cross. * mini-fix: update docs config for doxygen (#3411) * Remove STB nonsense todo assert. * docs: clarify Android API version requirement in README (#3414) Change Android version notation from "14+" to "4.0+ (API 14 or later)" for better clarity among Android developers * Fixed C++20 deprecated lambda capture. * Updated cgltf. * Updated meshoptimizer. * Updated glslang. * Updated spirv-headers. * Updated spirv-tools. * Updated spirv-cross. * Rebuilt metal & spir-v shaders. * Add a file formatting script (#3383) * Updated version. * Beef bindings: Fix int32_t as int32 --------- Co-authored-by: Aleš Mlakar <[email protected]> Co-authored-by: Бранимир Караџић <[email protected]> Co-authored-by: Daniel Kalmar <[email protected]> Co-authored-by: IchorDev <[email protected]> Co-authored-by: James Fulop <[email protected]> Co-authored-by: Martijn Courteaux <[email protected]> Co-authored-by: imaginaryPineapple <[email protected]> Co-authored-by: Raziel Alphadios <[email protected]> Co-authored-by: Matt Tytel <[email protected]> Co-authored-by: Nuno Silva <[email protected]> Co-authored-by: Bob Conan <[email protected]> Co-authored-by: luzpaz <[email protected]> Co-authored-by: Aaron Franke <[email protected]> Co-authored-by: attilaz <[email protected]> Co-authored-by: nathanstouffer <[email protected]> Co-authored-by: Kevin J. <[email protected]> Co-authored-by: Dipendra Sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was still getting some VK_DEVICE_LOST crashes and this fixes it. Followed some changes from 01af383#diff-4fe4dacbf31bf95719870316660d20e1deca6ebbfa3f39c6b2b8b0b302d629f9
@mcourteaux Does this look right to you?