[PM-27632] Add feature flag for sdk key rotation #6820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quexten
changed the title
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6820 +/- ##
==========================================
- Coverage 59.14% 55.69% -3.46%
==========================================
Files 1937 1939 +2
Lines 86026 86211 +185
Branches 7702 7703 +1
==========================================
- Hits 50878 48012 -2866
- Misses 33273 36392 +3119
+ Partials 1875 1807 -68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mzieniukbw
reviewed
Jan 10, 2026
src/Core/Constants.cs
Outdated
| public const string V2RegistrationTDEJIT = "pm-27279-v2-registration-tde-jit"; | ||
| public const string DataRecoveryTool = "pm-28813-data-recovery-tool"; | ||
| public const string EnableAccountEncryptionV2KeyConnectorRegistration = "enable-account-encryption-v2-key-connector-registration"; | ||
| public const string SdkKeyRotation = "sdk-key-rotation"; |
Contributor
There was a problem hiding this comment.
PM-27632 already introduces pm-27632-cipher-crud-operations-to-sdk feature flag. I would suggest to have a dedicated SDK key rotation Jira ticket and relevant feature flag tickets, to not mix those up.
Contributor
Author
There was a problem hiding this comment.
Renamed to include the ticket!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-27632
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes