Make CA1304 & CA1305 warnings

[justindbaur]

🎟️ Tracking

📔 Objective

This makes it a warning (which is upgraded to error by default) to not specify a CultureInfo or IFormatProvider when there is an overload that takes them. The default of .NET is to use the current culture but that can cause differences for people who have a different culture on their computer. Likely most of these warnings should have CultureInfo.InvariantCulture specified but that is a difference for what is happening today so a decision has to be made that it is correct for each place.

This helps make things like #6811 less likely to happen.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – c477279d-69f3-4384-aaed-388bf7339d6d

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.02%. Comparing base (6d69c9b) to head (3561573).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6813      +/-   ##
==========================================
+ Coverage   55.07%   59.02%   +3.95%     
==========================================
  Files        1934     1934              
  Lines       85777    85777              
  Branches     7675     7675              
==========================================
+ Hits        47238    50634    +3396     
+ Misses      36749    33269    -3480     
- Partials     1790     1874      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[withinfocus]

Lot of whitespace differences I had to temporarily disable, not sure we want those.

[justindbaur]

@withinfocus The Directory.Build.props one is relatively normal, our version bumping script leaves that file technically against our preferred formatting so if you edit that file in an IDE you'll get those.

The Scim integration test project is because it had CRLF line endings instead of LF defined by our editorconfig so VSCode updated it. I can change it back and update it separately if that is preferred though.

[AmyLGalles]

LGTM

[sbrown-livefront]

✅