Skip to content

Conversation

@ike-kottlowski
Copy link
Contributor

@ike-kottlowski ike-kottlowski commented Dec 30, 2025

🎟️ Tracking

PM-29568

📔 Objective

link styling was missed in previous PR.

Styling for footer links require style="text-decoration:none" color="#175ddc" font-weight="400"

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@ike-kottlowski ike-kottlowski requested review from a team as code owners December 30, 2025 23:14
@ike-kottlowski ike-kottlowski added the ai-review Request a Claude code review label Dec 30, 2025
@ike-kottlowski ike-kottlowski requested a review from rr-bw December 30, 2025 23:15
@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025

Logo
Checkmarx One – Scan Summary & Detailsc51511c9-2c0b-4a49-be26-e28185b8de9e

Great job! No new security vulnerabilities introduced in this pull request

@claude
Copy link
Contributor

claude bot commented Dec 30, 2025

Overall Assessment: REQUEST CHANGES

This PR updates email footer template styling to apply color and font-weight to footer links. The changes modify 1 MJML component and 6 generated HTML template files.

Code Review Details
  • ⚠️ IMPORTANT: Invalid HTML attribute usage - color and font-weight are CSS properties, not valid HTML attributes
    • src/Core/MailTemplates/Mjml/components/footer.mjml:48-49

🤖 Generated with Claude Code

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.83%. Comparing base (f82552f) to head (7896486).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6784      +/-   ##
==========================================
- Coverage   54.84%   54.83%   -0.02%     
==========================================
  Files        1920     1920              
  Lines       85255    85255              
  Branches     7633     7633              
==========================================
- Hits        46757    46746      -11     
- Misses      36718    36729      +11     
  Partials     1780     1780              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@enmande enmande self-requested a review December 31, 2025 20:22
@ike-kottlowski ike-kottlowski merged commit a2ba528 into main Jan 2, 2026
78 checks passed
@ike-kottlowski ike-kottlowski deleted the auth/pm-21741/fix-footer-color branch January 2, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants