-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[PM-30298] Initial documentation for OrganizationAbility pattern #6781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-30298] Initial documentation for OrganizationAbility pattern #6781
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6781 +/- ##
==========================================
- Coverage 54.83% 54.83% -0.01%
==========================================
Files 1920 1920
Lines 85259 85255 -4
Branches 7634 7633 -1
==========================================
- Hits 46756 46753 -3
+ Misses 36722 36721 -1
Partials 1781 1781 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Claude finished @eliykat's task in 4m 13s —— View job Overall Assessment: APPROVE This PR adds helpful documentation for the OrganizationAbility pattern, explaining how to add new plan-gated features. The documentation accurately reflects the codebase patterns and provides clear guidance for developers. The file was moved to co-locate with the OrganizationAbility class while intentionally maintaining the original namespace for backward compatibility. Code Review Details
🤖 Generated with Claude Code Co-Authored-By: Claude Sonnet 4.5 [email protected] |
src/Core/AdminConsole/OrganizationFeatures/OrganizationAbility/README.md
Show resolved
Hide resolved
src/Core/AdminConsole/OrganizationFeatures/OrganizationAbility/README.md
Show resolved
Hide resolved
src/Core/AdminConsole/OrganizationFeatures/OrganizationAbility/README.md
Show resolved
Hide resolved
src/Core/AdminConsole/OrganizationFeatures/OrganizationAbility/README.md
Show resolved
Hide resolved
src/Core/AdminConsole/OrganizationFeatures/OrganizationAbility/README.md
Outdated
Show resolved
Hide resolved
|
|
||
| 4. **Update organization creation/upgrade logic** — Ensure the ability is set based on the plan. | ||
|
|
||
| 5. **Update the organization license claims** (if applicable) - to make the feature available on self-hosted instances. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ QUESTION: What does "Update the organization license claims (if applicable)" mean and when is it applicable?
Context
This step lacks specificity for developers unfamiliar with the self-hosted licensing system. Based on the codebase, it appears to involve:
- Adding a constant to
OrganizationLicenseConstants.cs - Adding a claim in
OrganizationLicenseClaimsFactory.GenerateClaims()
However, the documentation doesn't explain:
- What files need updating
- When this step is required vs optional
- What "if applicable" means (all organization abilities? only certain ones?)
Could you clarify this step or provide more specific guidance? This would help developers know exactly what to do for self-hosted deployments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are going to discuss this with Billing Team and provide more detail here in a separate PR.

🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-30298
📔 Objective
Add initial documentation for how to add new plan features. More detail will follow, this is just to get some basic guidance close to code.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes