Skip to content

Conversation

@jholland-livefront
Copy link
Contributor

@jholland-livefront jholland-livefront commented Dec 18, 2025

🎟️ Tracking

PM-29459

📔 Objective

For this ticket we want to remove unused Autofill Feature Flags from the server code. 10 Feature flags have been removed and one, NotificationRefresh can be removed after the web-v2026.1.0 release. All code around these feature flags has been removed from clients and there are no references remaining in the server code.

BlockBrowserInjectionsByDomain, EnableNewCardCombinedExpiryAutofill, UseTreeWalkerApiForPageDetailsCollection
were removed after the web-v2025.8.0 release.
DelayFido2PageScriptInitWithinMv2 and IdpAutoSubmitLogin were removed after the web-v2025.6.0 release.
GenerateIdentityFillScriptRefactor was removed after the web-v2025.5.0 release.
InlineMenuPositioningImprovements was removed after the web-v2025.4.0 release.
NotificationBarAddLoginImprovements, InlineMenuFieldQualification, and InlineMenuTotp were removed after the web-v2025.3.0 release.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@claude
Copy link
Contributor

claude bot commented Dec 18, 2025

Claude finished @jholland-livefront's task in 1m 49s —— View job


Review Complete

Comprehensive verification confirms this PR is safe to merge.

Findings

  • All 10 removed feature flags verified with zero remaining references in server codebase
  • No references in configuration files (appsettings*.json)
  • No references in test files
  • Proper deprecation timeline followed (flags removed from clients in web-v2025.3.0 through web-v2025.8.0)
  • NotificationRefresh correctly retained for future removal after web-v2026.1.0
  • Clean removal with no breaking changes

Recommendation: Approve


@claude
Copy link
Contributor

claude bot commented Dec 18, 2025

Overall Assessment: APPROVE

Reviewed removal of 10 unused autofill feature flags from Constants.cs. All flags have been removed from clients in previous releases (web-v2025.3.0 through web-v2025.8.0), and verification confirms no remaining references in the server codebase.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

Logo
Checkmarx One – Scan Summary & Details516a7f37-6175-47a1-b01b-003660b7eedd

Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 105

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.71%. Comparing base (cc2d69e) to head (6543fde).
⚠️ Report is 37 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6749   +/-   ##
=======================================
  Coverage   54.71%   54.71%           
=======================================
  Files        1925     1925           
  Lines       85661    85661           
  Branches     7668     7668           
=======================================
+ Hits        46867    46868    +1     
+ Misses      37011    37010    -1     
  Partials     1783     1783           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jprusik jprusik added the ai-review Request a Claude code review label Jan 5, 2026
@jprusik jprusik self-assigned this Jan 6, 2026
@jprusik jprusik merged commit 2026ca1 into main Jan 6, 2026
44 checks passed
@jprusik jprusik deleted the autofill/PM-29459-remove-autofill-feature-flags branch January 6, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants