-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Remove unused feature flags for Autofill #6749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Claude finished @jholland-livefront's task in 1m 49s —— View job Review CompleteComprehensive verification confirms this PR is safe to merge. Findings
Recommendation: Approve |
|
Overall Assessment: APPROVE Reviewed removal of 10 unused autofill feature flags from Constants.cs. All flags have been removed from clients in previous releases (web-v2025.3.0 through web-v2025.8.0), and verification confirms no remaining references in the server codebase. |
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6749 +/- ##
=======================================
Coverage 54.71% 54.71%
=======================================
Files 1925 1925
Lines 85661 85661
Branches 7668 7668
=======================================
+ Hits 46867 46868 +1
+ Misses 37011 37010 -1
Partials 1783 1783 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ove-autofill-feature-flags


🎟️ Tracking
PM-29459
📔 Objective
For this ticket we want to remove unused Autofill Feature Flags from the server code. 10 Feature flags have been removed and one,
NotificationRefreshcan be removed after theweb-v2026.1.0release. All code around these feature flags has been removed fromclientsand there are no references remaining in theservercode.BlockBrowserInjectionsByDomain,EnableNewCardCombinedExpiryAutofill,UseTreeWalkerApiForPageDetailsCollectionwere removed after the
web-v2025.8.0release.DelayFido2PageScriptInitWithinMv2andIdpAutoSubmitLoginwere removed after theweb-v2025.6.0release.GenerateIdentityFillScriptRefactorwas removed after theweb-v2025.5.0release.InlineMenuPositioningImprovementswas removed after theweb-v2025.4.0release.NotificationBarAddLoginImprovements,InlineMenuFieldQualification, andInlineMenuTotpwere removed after theweb-v2025.3.0release.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes