Skip to content

Conversation

@jaasen-livefront
Copy link
Collaborator

@jaasen-livefront jaasen-livefront commented Nov 14, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-27884
https://bitwarden.atlassian.net/browse/PM-27885
https://bitwarden.atlassian.net/browse/PM-27886

📔 Objective

This is the first step in the process of migrating the cipher archiveDate to use the Cipher.Archives data column

Key Changes

  • Added sql and migration scripts to create the column

Updated the following:

  • Cipher Repository
  • Archive Ciphers Command
  • Unarchive Ciphers Command
  • CipherDetailsQuery

Notes

  • No behavior changes yet; archive logic still uses Cipher.ArchivedDate.

Testing Notes

Testing was done with archiving/unarchiving via the web client without issue.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jaasen-livefront jaasen-livefront requested review from a team as code owners November 14, 2025 02:48
@jaasen-livefront jaasen-livefront changed the title [PM-27884] - Archive Revamp: UserCipherArchive Table Migration [PM-27884] - Create CipherArchive Table Nov 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

Logo
Checkmarx One – Scan Summary & Details54e9d323-cf9d-43ae-903e-8f81f242779e

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 54.54545% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.97%. Comparing base (a6e034a) to head (b38ac70).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/Api/Vault/Controllers/CiphersController.cs 0.00% 22 Missing ⚠️
...tyFramework/Vault/Repositories/CipherRepository.cs 73.91% 3 Missing and 3 partials ⚠️
...ork/Repositories/Queries/UserCipherDetailsQuery.cs 76.47% 3 Missing and 1 partial ⚠️
src/Core/Vault/Commands/ArchiveCiphersCommand.cs 0.00% 0 Missing and 1 partial ⚠️
src/Core/Vault/Commands/UnarchiveCiphersCommand.cs 0.00% 0 Missing and 1 partial ⚠️
src/Core/Vault/Models/Data/CipherDetails.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6578      +/-   ##
==========================================
+ Coverage   55.04%   58.97%   +3.93%     
==========================================
  Files        1934     1934              
  Lines       85581    85638      +57     
  Branches     7656     7660       +4     
==========================================
+ Hits        47106    50508    +3402     
+ Misses      36686    33258    -3428     
- Partials     1789     1872      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@withinfocus
Copy link
Contributor

@jaasen-livefront
Copy link
Collaborator Author

nick-livefront
nick-livefront previously approved these changes Nov 19, 2025
Copy link
Contributor

@nick-livefront nick-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing jumps out to me, feels like claude has given some good feedback!

I agree with missing tests here but integration tests feel like they will be coming downstream with the follow up work

@jaasen-livefront jaasen-livefront changed the title [PM-27884] - Create CipherArchive Table [PM-27884] - Add Cipher Archives Dec 2, 2025
@bitwarden bitwarden deleted a comment from claude bot Dec 2, 2025
@jaasen-livefront jaasen-livefront marked this pull request as draft December 3, 2025 17:59
@jaasen-livefront jaasen-livefront changed the title [PM-27884] - Add Cipher Archives [PM-27884][PM-27886] - Add Cipher Archives Dec 3, 2025
shane-melton
shane-melton previously approved these changes Dec 16, 2025
@jaasen-livefront
Copy link
Collaborator Author

@jrmccannon Sorry just need one last approval. Ty!

jrmccannon
jrmccannon previously approved these changes Dec 17, 2025
@jaasen-livefront jaasen-livefront requested review from gbubemismith and removed request for gbubemismith and nick-livefront December 17, 2025 17:23
@jaasen-livefront jaasen-livefront changed the title [PM-27884][PM-27886][PM-27885] - Add Cipher Archives [PM-27884][PM-27886][PM-27885][PM-30448] - Add Cipher Archives Jan 5, 2026
@jaasen-livefront jaasen-livefront changed the title [PM-27884][PM-27886][PM-27885][PM-30448] - Add Cipher Archives [PM-27884][PM-27886][PM-27885] - Add Cipher Archives Jan 5, 2026
@jaasen-livefront jaasen-livefront removed the request for review from gbubemismith January 6, 2026 19:50
Copy link
Contributor

@rkac-bw rkac-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaasen-livefront jaasen-livefront removed the request for review from nick-livefront January 7, 2026 17:16
@jaasen-livefront jaasen-livefront merged commit 02c03f4 into main Jan 7, 2026
55 checks passed
@jaasen-livefront jaasen-livefront deleted the PM-27884 branch January 7, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants