[SM-1570] Adding new item to organization license to disable SM ads for users #6482
+11,182
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
New Issues (3)Checkmarx found the following issues in this Pull Request
|
…warden/server into SM-1571-DisableSMAdsForUsers
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6482 +/- ##
==========================================
+ Coverage 55.03% 58.97% +3.93%
==========================================
Files 1934 1934
Lines 85581 85611 +30
Branches 7656 7659 +3
==========================================
+ Hits 47098 50486 +3388
+ Misses 36695 33256 -3439
- Partials 1788 1869 +81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BTreston
previously approved these changes
Oct 27, 2025
Contributor
|
Claude finished @cd-bitwarden's task in 2m 51s —— View job Code Review Complete
The bitwarden-code-reviewer agent has completed its review and posted inline comments directly on the PR. |
mkincaid-bw
requested changes
Oct 30, 2025
Contributor
mkincaid-bw
left a comment
mkincaid-bw
left a comment
There was a problem hiding this comment.
Additional refresh statements needed, plus a question regarding casing.
util/Migrator/DbScripts/2025-12-18_00_AddDisableSMAdsForUsersToOrganization.sql
Show resolved
Hide resolved
cd-bitwarden
dismissed stale reviews from BTreston and cyprain-okeke
via
363fa4f
amorask-bitwarden
previously approved these changes
Dec 29, 2025
cturnbull-bitwarden
previously approved these changes
Jan 2, 2026
JimmyVo16
previously approved these changes
Jan 2, 2026
cd-bitwarden
dismissed stale reviews from JimmyVo16, cturnbull-bitwarden, amorask-bitwarden, and rkac-bw
via
5b59234
JimmyVo16
approved these changes
Jan 7, 2026
cyprain-okeke
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/SM-1740
https://bitwarden.atlassian.net/browse/SM-1742
📔 Objective
Adding the new column to the database for adding a new item to the organization table for "disabling SM ads for users", this new item is called UseDisableSMAdsForUsers.
📸 Screenshots
N/A
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes