remove unused globalSettings parameter from send responses

[audreyality]

🎟️ Tracking

#5895 - code review feedback

📔 Objective

Remove unused globalSettings parameter from send responses

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 47.84%. Comparing base (e8ad23c) to head (9dd2bbb).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/Api/Tools/Controllers/SendsController.cs	22.22%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6016      +/-   ##
==========================================
+ Coverage   47.83%   47.84%   +0.01%     
==========================================
  Files        1700     1702       +2     
  Lines       75484    75532      +48     
  Branches     6794     6799       +5     
==========================================
+ Hits        36107    36142      +35     
- Misses      37911    37923      +12     
- Partials     1466     1467       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Checkmarx One – Scan Summary & Details – e2c1084a-af64-47c2-b88f-a7de916b49bb

New Issues (5)

Checkmarx found the following issues in this Pull Request

Severity	Issue	Source File / Package	Checkmarx Insight
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 986	details Method at line 986 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows t... ID: 6ZJldlYxNyaOFlQgFiWdcAPh1TE%3D Attack Vector
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 917	details Method at line 917 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows t... ID: LCq5g1kzcN1X3wIhj3hMhlaop3k%3D Attack Vector
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 557	details Method at line 557 of /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs gets a parameter from a user request from model. This par... ID: bVhpH9B9I29J03V0RYbFCg94hQI%3D Attack Vector
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1106	details Method at line 1106 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from organizationId. This parameter ... ID: KHTgiaxE92NLpGDx2jf4I7zoqLc%3D Attack Vector
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 419	details Method at line 419 of /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs gets a parameter from a user request from model. This par... ID: 2VsVEkxsA86XkPTRWjCQgqhrZJM%3D Attack Vector

Fixed Issues (14)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	CVE-2022-37620	Npm-html-minifier-4.0.0
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1116
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 344
	CSRF	/src/Api/Billing/Controllers/VNext/OrganizationBillingVNextController.cs: 89
	CSRF	/src/Api/Billing/Controllers/VNext/ProviderBillingVNextController.cs: 81
	CSRF	/src/Api/Billing/Controllers/VNext/AccountBillingVNextController.cs: 57
	CSRF	/src/Api/Billing/Controllers/VNext/OrganizationBillingVNextController.cs: 43
	CSRF	/src/Api/Billing/Controllers/VNext/ProviderBillingVNextController.cs: 39
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 468
	Use_Of_Hardcoded_Password	/src/Identity/IdentityServer/RequestValidators/DeviceValidator.cs: 43
	Use_Of_Hardcoded_Password	/src/Core/KeyManagement/Sends/SendPasswordHasherServiceCollectionExtensions.cs: 14
	Use_Of_Hardcoded_Password	/src/Core/Constants.cs: 204
	CVE-2025-5889	Npm-brace-expansion-2.0.1
	CVE-2025-5889	Npm-brace-expansion-1.1.11

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[djsmith85]

This should only be removing the usage of unused globalSettings. The last commit (5f84072) introduces the new ISendOwnerQuery which was created for #5895. I think this might have been a bad merge/push.

You could either update this PR and we'll get it merged quickly, or close this and include the clean up on #5895