Skip to content

Conversation

@withinfocus
Copy link
Contributor

@withinfocus withinfocus commented Jun 7, 2025

🎟️ Tracking

Internal change.

📔 Objective

We are doing more than ever in this repo and are now even bringing documentation into README files, placing more demands on getting content well-formed and checked. We have experimented with the MegaLinter for quite some time and there is a case to use it across all our repos for basic formatting checks at a minimum, with the option to use their larger "flavors" as desired for even more linting. I will skip over the rationale and overview of that system, and in the end it brings a total linting package to us that we don't have to maintain, getting all its benefits rather effortlessly.

This change aims to try the formatters flavor out with both local linting and PR-based feedback. This flavor does not include much beyond basic ... format checks. When run locally, the pre-commit hook will take ~10 seconds to invoke the runner to give feedback -- this does have an expense, but fixes will be applied automatically. The online run just gives PR feedback; there is a way to also have it apply changes, but keeping that out of scope, at least for now. Only changed files are linted.

dotnet format was the only linter used here, and that's included in the formatters flavor as well as several others.

Should this be accepted and trialed, we can proceed with a more template-based introduction.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@codecov
Copy link

codecov bot commented Jun 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.06%. Comparing base (8387996) to head (0af26c1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5938      +/-   ##
==========================================
- Coverage   55.08%   55.06%   -0.02%     
==========================================
  Files        1934     1934              
  Lines       85777    85777              
  Branches     7675     7675              
==========================================
- Hits        47246    47234      -12     
- Misses      36740    36752      +12     
  Partials     1791     1791              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2025

Logo
Checkmarx One – Scan Summary & Detailsd5ae03a0-7f82-4c5b-98f7-c432d42faade

Great job! No new security vulnerabilities introduced in this pull request

@sonarqubecloud
Copy link

@withinfocus withinfocus closed this Jan 7, 2026
@withinfocus withinfocus reopened this Jan 7, 2026
withinfocus and others added 2 commits January 7, 2026 18:10
Resolved conflicts in .github/workflows/build.yml by accepting the lint job from main.

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants