Skip to content

Conversation

@tangowithfoxtrot
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1603

📔 Objective

When working on #1344, I added some code docs for the new generator that should work with common IDEs.

This just adds equivalent docs for the rest of the Python SDK.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@tangowithfoxtrot tangowithfoxtrot requested a review from a team as a code owner September 29, 2025 17:19
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details831179cf-5a7e-4773-bf0f-6915701795b8

Great job! No new security vulnerabilities introduced in this pull request

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 7.32%. Comparing base (ee918c9) to head (bde8d44).

Additional details and impacted files
@@                         Coverage Diff                         @@
##           add-generate-function-to-python-sdk   #1345   +/-   ##
===================================================================
  Coverage                                 7.32%   7.32%           
===================================================================
  Files                                       20      20           
  Lines                                     1378    1378           
===================================================================
  Hits                                       101     101           
  Misses                                    1277    1277           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cd-bitwarden
cd-bitwarden previously approved these changes Sep 30, 2025
Copy link
Contributor

@cd-bitwarden cd-bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from add-generate-function-to-python-sdk to main October 21, 2025 20:19
@tangowithfoxtrot tangowithfoxtrot dismissed cd-bitwarden’s stale review October 21, 2025 20:19

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants