Skip to content

Conversation

@quexten
Copy link
Contributor

@quexten quexten commented Dec 2, 2025

🎟️ Tracking

📔 Objective

🚨 Breaking Changes

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Logo
Checkmarx One – Scan Summary & Details65d2a593-0ed6-4c62-8fa9-337f11a665a9

Great job! No new security vulnerabilities introduced in this pull request

@quexten quexten changed the base branch from main to km/account-cryptographic-state December 2, 2025 17:22
@quexten quexten changed the title km/tde registration Implement Registration for TDE Users Dec 2, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2025

Base automatically changed from km/account-cryptographic-state to main December 3, 2025 11:16
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

🔍 SDK Breaking Change Detection Results

SDK Version: km/tde-registration (fa73276)
Completed: 2025-12-05 13:32:20 UTC
Total Time: 244s

Client Status Details
typescript ✅ No breaking changes detected TypeScript compilation passed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 0.81301% with 122 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.44%. Comparing base (ab7ae36) to head (fa73276).

Files with missing lines Patch % Lines
crates/bitwarden-auth/src/registration.rs 0.00% 75 Missing ⚠️
...bitwarden-core/src/key_management/crypto_client.rs 0.00% 45 Missing ⚠️
.../src/key_management/account_cryptographic_state.rs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
- Coverage   79.74%   79.44%   -0.30%     
==========================================
  Files         304      304              
  Lines       32757    32880     +123     
==========================================
+ Hits        26121    26122       +1     
- Misses       6636     6758     +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants