Skip to content

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Oct 15, 2025

🎟️ Tracking

📔 Objective

One of the goals of the safe primitives is to make them server validateable. Encrypted objects contain an "encrypted by" key id. Similarly, objects should include the contained key id, so that the server can match these and validate them.

This adds the contained key id to the password protected key envelope. We don't need to consider the backward compatibility case because currently all users are V1 users with AES keys who do not have a key id, and the only use-case is PIN keys.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsaeb76459-8600-4c19-89a7-7239ec138835

Great job! No new security vulnerabilities introduced in this pull request

Copy link

Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.01%. Comparing base (cc36132) to head (9074418).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
.../bitwarden-crypto/src/keys/symmetric_crypto_key.rs 83.33% 1 Missing ⚠️
...crypto/src/safe/password_protected_key_envelope.rs 97.43% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #514      +/-   ##
==========================================
+ Coverage   77.97%   78.01%   +0.03%     
==========================================
  Files         287      287              
  Lines       27673    27713      +40     
==========================================
+ Hits        21579    21620      +41     
+ Misses       6094     6093       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant