-
Notifications
You must be signed in to change notification settings - Fork 20
[PM-24468] Introduce CipherRiskClient #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 31 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
a10fef6
[PM-24468] Introduce CipherRiskClient
shane-melton 12f17c0
[PM-24468] Add concurrency support for compute_risk in CipherRiskClient
shane-melton cffd1df
[PM-24468] Use Arc for password_map to avoid expensive clones
shane-melton d803671
[PM-24468] Fix magic values
shane-melton b327c24
[PM-24468] Remove redundant tests
shane-melton cc28aab
[PM-24468] Sort Vault Cargo.toml
shane-melton 25ecee3
[PM-24468] Fix cargo.toml formatting
shane-melton 5daddda
[PM-24468] Better empty password handling
shane-melton 56fe325
[PM-24468] Strip URL from HIBP errors
shane-melton c5b7e40
[PM-24468] Use Option<u32> for reuse_count result
shane-melton 1956e61
[PM-24468] Refactor HIBP exposure handling to capture errors per-ciphโฆ
shane-melton 678856f
[PM-24468] Update exposed password result type
shane-melton 6fe90ea
Merge branch 'main' into vault/pm-24468/cipher-risk-client
shane-melton 3a97ee0
[PM-24468] Add default serialization for CipherRiskOptions fields
shane-melton 1ea9850
[PM-24468] Use option chaining and iterators to improve readability
shane-melton 5cc8069
[PM-24468] Use constructor function for PasswordReuseMap
shane-melton 757fda1
[PM-24468] Expose ExposedPasswordResult enum
shane-melton b7d3077
[PM-24468] Add to_cipher_risk helper
shane-melton 76f83f7
[PM-24468] Remove unnecessary Result return type
shane-melton 4c1cce2
[PM-24468] Revert making password_reuse_map static
shane-melton 02e0ce5
Merge branch 'main' into vault/pm-24468/cipher-risk-client
shane-melton ed87d35
Merge branch 'main' into vault/pm-24468/cipher-risk-client
shane-melton d201755
[PM-24468] Remove unused to_login_details helper
shane-melton 9b8b001
[PM-24468] Make CipherId required for CipherLoginDetails and CipherRisk
shane-melton 5d0e1d2
[PM-24468] Move cipher_risk to its own module
shane-melton a30d67b
[PM-24468] Move HIBP logic to its own module
shane-melton ac5c2f0
[PM-24468] Cleanup cipher risk module exports
shane-melton 4795415
[PM-24468] Rename CipherRisk to CipherRiskResult
shane-melton c039308
[PM-24468] Update futures and zxcvbn dependencies to use workspace coโฆ
shane-melton c90e779
[PM-24468] Formatting
shane-melton 46a1b7a
Merge branch 'main' into vault/pm-24468/cipher-risk-client
shane-melton bc1808f
[PM-24468] Remove unused pub(super)
shane-melton 5f76d84
Merge branch 'main' into vault/pm-24468/cipher-risk-client
shane-melton 02f5614
[PM-24468] Use workspace version of zxcvbn in bitwarden-core
shane-melton 8f99253
Merge branch 'main' into vault/pm-24468/cipher-risk-client
shane-melton a192f62
Merge branch 'main' into vault/pm-24468/cipher-risk-client
shane-melton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (blocker): Please update
bitwarden-coreto reference the workspace version.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed 02f5614