Skip to content

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented Oct 8, 2025

🎟️ Tracking

📔 Objective

Publish a commercial version of the SDK to NPM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Oct 8, 2025

Logo
Checkmarx One – Scan Summary & Detailsa5f7c2f1-676e-4099-ab91-1eabab02a363

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.98%. Comparing base (80fbec9) to head (675243f).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #496   +/-   ##
=======================================
  Coverage   77.98%   77.98%           
=======================================
  Files         287      287           
  Lines       27672    27672           
=======================================
  Hits        21579    21579           
  Misses       6093     6093           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coroiu coroiu force-pushed the PM-25901-publish-bitwarden-licensed-sdk-to-npm branch from 1b60b16 to 675243f Compare October 8, 2025 12:43
Copy link

sonarqubecloud bot commented Oct 8, 2025

@coroiu coroiu marked this pull request as ready for review October 8, 2025 13:01
@coroiu coroiu requested a review from a team as a code owner October 8, 2025 13:01
@coroiu coroiu requested a review from michalchecinski October 8, 2025 13:01
@coroiu coroiu merged commit 41674ea into main Oct 10, 2025
56 checks passed
@coroiu coroiu deleted the PM-25901-publish-bitwarden-licensed-sdk-to-npm branch October 10, 2025 09:40
bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants