Skip to content

Commit 7b5d9db

Browse files
abergsHinton
andauthored
PM-23661: CXF - Export Identity (#413)
## ๐ŸŽŸ๏ธ Tracking https://bitwarden.atlassian.net/browse/PM-23661 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## ๐Ÿ“” Objective This PR maps BW Identity to one or multiple CXF Credentials <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## โฐ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## ๐Ÿฆฎ Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - ๐Ÿ‘ (`:+1:`) or similar for great changes - ๐Ÿ“ (`:memo:`) or โ„น๏ธ (`:information_source:`) for notes or general info - โ“ (`:question:`) for questions - ๐Ÿค” (`:thinking:`) or ๐Ÿ’ญ (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - ๐ŸŽจ (`:art:`) for suggestions / improvements - โŒ (`:x:`) or โš ๏ธ (`:warning:`) for more significant problems or concerns needing attention - ๐ŸŒฑ (`:seedling:`) or โ™ป๏ธ (`:recycle:`) for future improvements or indications of technical debt - โ› (`:pick:`) for minor or nitpick changes --------- Co-authored-by: Oscar Hinton <[email protected]>
1 parent 2e7f960 commit 7b5d9db

File tree

2 files changed

+471
-4
lines changed

2 files changed

+471
-4
lines changed

โ€Žcrates/bitwarden-exporters/src/cxf/export.rsโ€Ž

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,7 @@ impl From<CipherType> for Vec<Credential> {
7979
match value {
8080
CipherType::Login(login) => (*login).into(),
8181
CipherType::Card(card) => (*card).into(),
82-
// TODO(PM-15451): Add support for identities.
83-
CipherType::Identity(_) => vec![],
82+
CipherType::Identity(identity) => (*identity).into(),
8483
// Secure Notes only contains a note field which is handled by `TryFrom<Cipher> for
8584
// Item`.
8685
CipherType::SecureNote(_) => vec![],

0 commit comments

Comments
ย (0)