Skip to content

Commit 2e7f960

Browse files
authored
[PM-25330] Fix B64 type (#417)
## ๐ŸŽŸ๏ธ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-25330 ## ๐Ÿ“” Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> Currently `bitwarden_wasm_internal.d.ts` produces: ``` export type B64 = String; ``` This PR makes it produce: ``` export type B64 = string; ``` In TypeScript the `string` primitive is case sensitive. This was causing breaking changes to TS clients. ## โฐ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## ๐Ÿฆฎ Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - ๐Ÿ‘ (`:+1:`) or similar for great changes - ๐Ÿ“ (`:memo:`) or โ„น๏ธ (`:information_source:`) for notes or general info - โ“ (`:question:`) for questions - ๐Ÿค” (`:thinking:`) or ๐Ÿ’ญ (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - ๐ŸŽจ (`:art:`) for suggestions / improvements - โŒ (`:x:`) or โš ๏ธ (`:warning:`) for more significant problems or concerns needing attention - ๐ŸŒฑ (`:seedling:`) or โ™ป๏ธ (`:recycle:`) for future improvements or indications of technical debt - โ› (`:pick:`) for minor or nitpick changes
1 parent a1611ee commit 2e7f960

File tree

1 file changed

+1
-1
lines changed
  • crates/bitwarden-encoding/src

1 file changed

+1
-1
lines changed

โ€Žcrates/bitwarden-encoding/src/b64.rsโ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ use crate::FromStrVisitor;
1616
#[serde(into = "String")]
1717
#[derive(Tsify)]
1818
#[tsify(into_wasm_abi, from_wasm_abi)]
19-
pub struct B64(#[tsify(type = "String")] Vec<u8>);
19+
pub struct B64(#[tsify(type = "string")] Vec<u8>);
2020

2121
/// Base64 encoded data
2222
///

0 commit comments

Comments
ย (0)