Skip to content

[pm-44416] Add forms map entry for accounts.google.com - #63

Merged
bensbits91 merged 2 commits into
mainfrom
pm-44416-google
Oct 5, 2026
Merged

bensbits91 merged 2 commits into
mainfrom
pm-44416-google

Conversation

@bensbits91

@bensbits91 bensbits91 commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

🎟️ Tracking

PM-44416

📔 Objective

Add forms map entry for accounts.google.com

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>
@bensbits91 bensbits91 self-assigned this Oct 2, 2026
@bensbits91 bensbits91 added the ai-review-vnext Request a Claude code review using the vNext workflow label Oct 2, 2026
@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Re-reviewed the single changed file, maps/forms/forms.jsonc, which adds an accounts.google.com host entry covering the two-step sign-in flow at /v3/signin/identifier and /v3/signin/challenge/pwd. The previously raised finding is resolved by commit 789b558: the combined "Email or phone" input is now mapped under email, phone, and username, which matches the Authentication field-key rule in maps/forms/README.md and the tiktok.com one-input-many-keys precedent in the same file. The entry is schema-valid for both pathname keys and the account-login category field restrictions, the host key is not duplicated, every selector segment carries a tag anchor as the selector philosophy requires, and the reCAPTCHA input is deliberately left unmapped per the "do not map captchas" guideline. Omitting container is justified in the entry comment, and the name='Passwd'-only password selector is explained by the type/autocomplete flip that "Show password" triggers.

No new findings.

Comment thread maps/forms/forms.jsonc Outdated
Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>
@bensbits91
bensbits91 marked this pull request as ready for review October 2, 2026 19:36
@bensbits91
bensbits91 requested a review from a team as a code owner October 2, 2026 19:36
@bensbits91
bensbits91 merged commit 924680b into main Oct 5, 2026
18 checks passed
@bensbits91
bensbits91 deleted the pm-44416-google branch October 5, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants