-
Notifications
You must be signed in to change notification settings - Fork 81
Update SDK to 7b3e4ed (1.0.0-3220-4b0d128) #2164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2164 +/- ##
==========================================
- Coverage 85.39% 84.09% -1.30%
==========================================
Files 1731 1982 +251
Lines 145718 161115 +15397
==========================================
+ Hits 124433 135487 +11054
- Misses 21285 25628 +4343 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Claude finished @bw-ghapp[bot]'s task —— View job SDK Update ReviewSummary: This PR updates the SDK from revision FindingsFinding 1: PR description lacks test plan and verification details💭 The PR description references SDK-internal changes but doesn't explain:
Recommendation: Add a test plan section describing verification steps, particularly for the renamed client type and logging changes. Suggested PR description improvements## Test Plan
- [ ] Verified app builds successfully with updated SDK
- [ ] Ran full test suite (Password Manager & Authenticator)
- [ ] Confirmed no breaking changes from SDK rename (BitwardenClient → PasswordManagerClient)
- [ ] Validated logging behavior remains consistent
- [ ] Tested RSA key operations (if applicable in iOS app)Finding 2: No breaking changes detected in iOS codebase✅ The SDK changelog mentions renaming Verified: Searched for both SDK Changes AnalysisThe update includes 35 commits with these key changes:
Impact Assessment: Low risk - mostly internal SDK improvements with one new feature (RSA key extraction). No breaking API changes affecting iOS app. Good Practices Observed
CI Status
RecommendationThis SDK update appears safe to merge once CI tests complete successfully. The changes are internal to the SDK with no breaking API changes affecting the iOS codebase. Action Items:
|

Updates the SDK from
e8560fd03e0db94a84edb67c727cdaa5cbad5f47to7b3e4edd2bdc10f1fee0be77a1190a502e9c10d4What's Changed
logwithtracingsdk-internal#573Raw changelog