Skip to content

Conversation

@bw-ghapp
Copy link
Contributor

@bw-ghapp bw-ghapp bot commented Nov 25, 2025

Updates the SDK from e8560fd03e0db94a84edb67c727cdaa5cbad5f47 to 7b3e4edd2bdc10f1fee0be77a1190a502e9c10d4

What's Changed

Raw changelog
- [PM-27530] Rename BitwardenClient to PasswordManagerClient (#571)
- Replace `log` with `tracing` (#573)
- Clippy disallow log crate macros (#581)
- Add rsa extract public key (#572)
- Fix vscode features (#584)

@bw-ghapp bw-ghapp bot added automated-pr PR created by workflow or other automation t:ci Updates to automated workflows labels Nov 25, 2025
@bw-ghapp bw-ghapp bot requested review from a team and matt-livefront as code owners November 25, 2025 12:24
@bw-ghapp bw-ghapp bot added automated-pr PR created by workflow or other automation t:ci Updates to automated workflows labels Nov 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

Logo
Checkmarx One – Scan Summary & Details96f4a57d-8ea8-4ec2-aac0-cfd2266dfc5e

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.09%. Comparing base (ff2b88c) to head (7f583de).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2164      +/-   ##
==========================================
- Coverage   85.39%   84.09%   -1.30%     
==========================================
  Files        1731     1982     +251     
  Lines      145718   161115   +15397     
==========================================
+ Hits       124433   135487   +11054     
- Misses      21285    25628    +4343     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bw-ghapp bw-ghapp bot changed the title Update SDK to 1e42d3e (1.0.0-3214-efed963) Update SDK to 7b3e4ed (1.0.0-3220-4b0d128) Nov 26, 2025
@LRNcardozoWDF LRNcardozoWDF enabled auto-merge (squash) November 26, 2025 23:57
@claude
Copy link

claude bot commented Nov 26, 2025

Claude finished @bw-ghapp[bot]'s task —— View job


SDK Update Review

Summary: This PR updates the SDK from revision e8560fd to 7b3e4ed (35 commits, version 1.0.0-3185 → 1.0.0-3220). The changes are minimal (2 files) and represent a standard dependency update with internal SDK improvements.


Findings

Finding 1: PR description lacks test plan and verification details

💭 The PR description references SDK-internal changes but doesn't explain:

  • How this update was tested in the iOS app context
  • Whether manual testing was performed
  • If any behavioral changes are expected from the SDK updates (logging changes, RSA key extraction, etc.)

Recommendation: Add a test plan section describing verification steps, particularly for the renamed client type and logging changes.

Suggested PR description improvements
## Test Plan
- [ ] Verified app builds successfully with updated SDK
- [ ] Ran full test suite (Password Manager & Authenticator)
- [ ] Confirmed no breaking changes from SDK rename (BitwardenClient → PasswordManagerClient)
- [ ] Validated logging behavior remains consistent
- [ ] Tested RSA key operations (if applicable in iOS app)

Finding 2: No breaking changes detected in iOS codebase

✅ The SDK changelog mentions renaming BitwardenClient to PasswordManagerClient, but neither type is directly referenced in the iOS codebase. The iOS app appears to use the SDK through abstracted interfaces, which shields it from this breaking change.

Verified: Searched for both BitwardenClient and PasswordManagerClient - no matches found in Swift files.


SDK Changes Analysis

The update includes 35 commits with these key changes:

  • PM-27530: Rename BitwardenClient to PasswordManagerClient (no iOS impact)
  • SDK-internal#573: Replace log with tracing (internal logging improvement)
  • SDK-internal#581: Clippy disallow log crate macros (Rust tooling)
  • SDK-internal#572: Add RSA extract public key (new functionality)
  • SDK-internal#584: Fix vscode features (development tooling)

Impact Assessment: Low risk - mostly internal SDK improvements with one new feature (RSA key extraction). No breaking API changes affecting iOS app.


Good Practices Observed

  • Automated dependency updates via bot
  • CI checks pass (Lint ✅, Security scan ✅)
  • Clean commit history with descriptive messages
  • Version comments in project-common.yml for tracking

CI Status

  • ✅ Lint workflow: SUCCESS
  • ✅ Checkmarx security scan: No new vulnerabilities
  • 🔄 Test suites: In progress (Password Manager, Authenticator)
  • 🔄 Code review workflow: In progress

Recommendation

This SDK update appears safe to merge once CI tests complete successfully. The changes are internal to the SDK with no breaking API changes affecting the iOS codebase.

Action Items:

  1. ✅ Monitor test suite completion
  2. 💭 Consider adding test plan to PR description for future SDK updates

@LRNcardozoWDF LRNcardozoWDF merged commit 8ce5d66 into main Nov 27, 2025
15 checks passed
@LRNcardozoWDF LRNcardozoWDF deleted the sdlc/sdk-update branch November 27, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-pr PR created by workflow or other automation t:ci Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants