Implement reusable Claude code review workflow #2064
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2064 +/- ##
==========================================
- Coverage 85.31% 82.97% -2.34%
==========================================
Files 1691 1987 +296
Lines 144372 161193 +16821
==========================================
+ Hits 123164 133744 +10580
- Misses 21208 27449 +6241 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -0,0 +1,11 @@ | |||
| # Bitwarden iOS Password Manager & Authenticator Apps | |||
There was a problem hiding this comment.
🤔 We do have a much more expansive Claude configuration being discussed in #2039; we might need to do some finagling of merging them together for this
There was a problem hiding this comment.
👋🏼 @KatherineInCode That's a heck of a lot of good work that y'all have started. Y'all have an awesome set of agents ready!
But, forgive me, I cannot see a CLAUDE.md file in the PR at either the root of the repo or in the .claude folder.
The intent of this PR is to spark a fire to get the automated pull request and '@claude' interation working in this repo. The goal is to have collaboration and suggestions from the mobile team to complete that file 😁
There was a problem hiding this comment.
@theMickster At some point that PR had a Claude.md file, though we moved away from that a bit. @fedemkr can probably provide more context
There was a problem hiding this comment.
A Claude.md may not be the best choice for what the team is trying to accomplish in #2039. What we are targeting here, is code reviews and prompt responses from either issues raised or PR comments. To the best of my limited knowledge, we need to have that file for Claude Code to do its thing on our PRs
There was a problem hiding this comment.
Hi @theMickster I think we can combine both approaches where in the CLAUDE.md file we tell it to use the proper Agent where possible; which will by default use the general guidance explained in the CLAUDE.md file when no Agent is good for the prompt being executed.
There was a problem hiding this comment.
I haven't the slightest idea if that will work with the Claude Actions code review flow, but I am willing to try + iterate together if you are 😁
How would we craft the CLAUDE.md here to do such a thing?🤔
There was a problem hiding this comment.
Nice to have the review code prompt already configured! 😄
I just have some improvement suggestions, lmk what you think and if you want me to commit them.
Also was thinking on first merging this PR and the accommodating the other one having the CLAUDE.md set up.
Totally cool by me! Please let me know if I can help after the merge or if you've got it. Always here to serve :-) |
|
Warning @theMickster Uploading code coverage report failed. Please check the "Upload to codecov.io" step of Process Test Reports job for more details. |
|
Warning @theMickster Uploading code coverage report failed. Please check the "Upload to codecov.io" step of Process Test Reports job for more details. |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-26935
📔 Objective
Ready to go full throttle with Claude code reviews using our reusable workflow.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes