[PM-18068] feat: Updated View cipher view UI with favicon and header section #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llection/folder header section.
fedemkr
changed the title
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1484 +/- ##
==========================================
- Coverage 89.63% 85.92% -3.72%
==========================================
Files 779 989 +210
Lines 48751 59147 +10396
==========================================
+ Hits 43698 50821 +7123
- Misses 5053 8326 +3273 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...ion/Support/Images.xcassets/Icons/Cards/amex.imageset/Brand=American Express, Theme=Dark.pdf
Outdated
Show resolved
Hide resolved
...ared/UI/Platform/Application/Support/Images.xcassets/Icons/business16.imageset/Contents.json
Outdated
Show resolved
Hide resolved
Comment on lines
126
to
129
| for await value in await services.stateService.showWebIconsPublisher().values { | ||
| guard case var .data(cipherState) = state.loadingState else { continue } | ||
| cipherState.showWebIcons = value | ||
| state.loadingState = .data(cipherState) |
There was a problem hiding this comment.
❓ Could this cause a race condition if showWebIconsPublisher publishes a value before the cipher data is loaded, then the showWebIcons value wouldn't be set? If so, could showWebIcons be moved into ViewItemState?
There was a problem hiding this comment.
@fedemkr One last question on this ☝️. When I tested it, the web icons were still loading with the show web icons toggle off so I'm guessing this data is loading before the cipher loads.
There was a problem hiding this comment.
That's a really good catch! I'll look into it and fix it thanks Matt!
BitwardenShared/UI/Vault/VaultItem/ViewItem/ViewItemProcessor.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Vault/VaultItem/ViewItem/ViewVaultItemState.swift
Outdated
Show resolved
Hide resolved
...iewItem/__Snapshots__/ViewItemViewTests/test_snapshot_identity_withAllValues_largeText.1.png
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Vault/VaultItem/ViewItem/ViewItemProcessor.swift
Outdated
Show resolved
Hide resolved
# Conflicts: # BitwardenShared/UI/Vault/VaultItem/VaultItemCoordinator.swift # BitwardenShared/UI/Vault/VaultItem/ViewItem/ViewItemProcessor.swift # BitwardenShared/UI/Vault/VaultItem/ViewItem/ViewItemProcessorTests.swift # BitwardenShared/UI/Vault/VaultItem/ViewItem/ViewItemState.swift
…a, some comment fixes, refactor of cipher state collections naming and computed properties.
…otten instead of using a publisher to avoid race condition issues. Fix lint warnings as well.
# Conflicts: # BitwardenShared/UI/Platform/Application/Support/Localizations/en.lproj/Localizable.strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-18068
📔 Objective
Update View cipher view UI with favicon and new header section with organization, collections and folder.
This also includes adding card images for known brands that are displayed on the view cipher view instead of the favicon.
Additionally, split
CipherItemStateTestsso the file doesn't get huge.📸 Screenshots
View Cipher screen header collapsed
View Cipher screen header expanded
View Cipher screen with visa card
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes