[PM-19372] feat: Log out all accounts App Intent #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedemkr
requested review from
matt-livefront,
phil-livefront,
brant-livefront,
ezimet-livefront and
a team
as code owners
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## PM-19045/lock-app-intents #1444 +/- ##
=============================================================
+ Coverage 85.76% 89.46% +3.69%
=============================================================
Files 993 777 -216
Lines 58708 48497 -10211
=============================================================
- Hits 50353 43388 -6965
+ Misses 8355 5109 -3246 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| static var description = IntentDescription("LogOutAllAccounts") | ||
|
|
||
| static var openAppWhenRun: Bool = false |
There was a problem hiding this comment.
🔨 looks like these are from AppIntent but it might be helpful to add some docs for these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-19372
📔 Objective
Implemented Log out all accounts App Intent and its Shortcut configuration.
ℹ️ No need for
PendingAppIntentActionas the logout will be triggered inAppProcessor -> checkIfExtensionSwitchedAccounts()when going back to foreground.📸 Screenshots
Log out all accounts shortcut
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes