Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-18976] feat: Enhance iOS integration with AppIntents and AppShortcuts #1433

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

fedemkr
Copy link
Member

@fedemkr fedemkr commented Mar 13, 2025

🎟️ Tracking

PM-18976

📔 Objective

Implement App Intents and Shortcuts to allow users to have a richer experience while using their device with the Password Manager app.

📸 Screenshots

TBD

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@fedemkr fedemkr self-assigned this Mar 13, 2025
@fedemkr fedemkr added enhancement New feature or request app:password-manager labels Mar 13, 2025
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.86%. Comparing base (86279ec) to head (9458919).

Files with missing lines Patch % Lines
...ared/Core/Platform/Services/ServiceContainer.swift 0.00% 3 Missing ⚠️
Bitwarden/Application/AppDelegate.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1433      +/-   ##
==========================================
- Coverage   89.63%   85.86%   -3.78%     
==========================================
  Files         779      987     +208     
  Lines       48751    58838   +10087     
==========================================
+ Hits        43698    50521    +6823     
- Misses       5053     8317    +3264     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Mar 13, 2025

Logo
Checkmarx One – Scan Summary & Detailsfb383901-cb89-4f6b-85de-dd6985444208

Great job, no security vulnerabilities found in this Pull Request

@fedemkr fedemkr added the hold This shouldn't be merged yet label Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:password-manager enhancement New feature or request hold This shouldn't be merged yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant