Skip to content

Conversation

@pixman20
Copy link
Contributor

@pixman20 pixman20 commented Oct 24, 2025

🎟️ Tracking

BRE-1272

📔 Objective

  • Adding custom label support for SM operator
  • Added tests to verify custom labels are on all SM Operator resources

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025

Logo
Checkmarx One – Scan Summary & Detailsd76d8f45-6ee3-45b2-8f46-5c6adb8f79f0

Great job! No new security vulnerabilities introduced in this pull request

@pixman20 pixman20 marked this pull request as ready for review October 24, 2025 22:20
@pixman20 pixman20 requested a review from a team as a code owner October 24, 2025 22:20
@pixman20 pixman20 requested review from mimartin12 and removed request for a team October 24, 2025 22:20
Copy link
Collaborator

@mimartin12 mimartin12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pixman20 pixman20 merged commit 9c6df7d into main Oct 27, 2025
13 checks passed
@pixman20 pixman20 deleted the BRE-1272-add-support-for-custom-labels-to-sm-operator branch October 27, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants