Skip to content

Conversation

sbrown-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-25123

📔 Objective

Removes the unused verify bank request object since older verify bank code was removed in #16532

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@sbrown-livefront sbrown-livefront self-assigned this Oct 17, 2025
Copy link

Copy link
Contributor

github-actions bot commented Oct 17, 2025

Logo
Checkmarx One – Scan Summary & Details3c5ead52-3e1c-4f3d-a326-369adab8d045

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.19%. Comparing base (d65824e) to head (65e1540).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16923      +/-   ##
==========================================
- Coverage   39.20%   39.19%   -0.01%     
==========================================
  Files        3463     3462       -1     
  Lines       98126    98125       -1     
  Branches    14736    14736              
==========================================
- Hits        38469    38463       -6     
- Misses      57991    57997       +6     
+ Partials     1666     1665       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sbrown-livefront sbrown-livefront requested review from a team and amorask-bitwarden and removed request for a team October 17, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant