Skip to content

Conversation

cyprain-okeke
Copy link
Contributor

@cyprain-okeke cyprain-okeke commented Oct 17, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-27050

📔 Objective

The newly implemented PremiumVNextComponent does not maintain the original, Self-Hosted version of the component
In Self-Host, the PremiumComponent is supposed to show the design I put in the ticket description, but based on your code for PremiumVNextComponent , that's not included.

If we flipped the feature flag for your ticket, I don't think there would be a way for a Self-Hosted user to upload a Premium License

📸 Screenshots

Screenshot 2025-10-17 at 6 03 34 PM
Screen.Recording.2025-10-17.at.5.11.59.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cyprain-okeke cyprain-okeke requested a review from a team as a code owner October 17, 2025 08:34
@cyprain-okeke cyprain-okeke requested a review from kdenney October 17, 2025 08:34
Copy link
Contributor

github-actions bot commented Oct 17, 2025

Logo
Checkmarx One – Scan Summary & Detailscc67bbe7-c883-4711-b2a9-626edc98ff13

Great job! No new security vulnerabilities introduced in this pull request

@amorask-bitwarden amorask-bitwarden changed the title [PM-27050]Fix : Cannot upload self-hosted license on new Premium page [PM-27050] Fix : Cannot upload self-hosted license on new Premium page Oct 17, 2025
Copy link
Contributor

@amorask-bitwarden amorask-bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ I think the requirements for the defect were to maintain the original self-hosted version of the Premium page when the user's in a self-hosted environment.

This change just tacks on the self-hosted license uploader to the new pricing card format, but a self-hosted user can't interact with a pricing card because you can't purchase subscriptions on a self-hosted instance.

On a self-hosted instance, the user should see the following until we have new designs:
image

Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.19%. Comparing base (97906ff) to head (0dbe9fc).
⚠️ Report is 21 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ng/individual/individual-billing-routing.module.ts 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16919      +/-   ##
==========================================
- Coverage   39.20%   39.19%   -0.02%     
==========================================
  Files        3463     3463              
  Lines       98181    98188       +7     
  Branches    14750    14750              
==========================================
- Hits        38494    38486       -8     
- Misses      58024    58038      +14     
- Partials     1663     1664       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@cyprain-okeke cyprain-okeke merged commit f1340c6 into main Oct 21, 2025
51 checks passed
@cyprain-okeke cyprain-okeke deleted the pm-27050-cannot-upload-self-hosted-license-on-new-premium-page branch October 21, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants