-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[PM-27050] Fix : Cannot upload self-hosted license on new Premium page #16919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-27050] Fix : Cannot upload self-hosted license on new Premium page #16919
Conversation
…n-new-premium-page
Great job! No new security vulnerabilities introduced in this pull request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ I think the requirements for the defect were to maintain the original self-hosted version of the Premium page when the user's in a self-hosted environment.
This change just tacks on the self-hosted license uploader to the new pricing card format, but a self-hosted user can't interact with a pricing card because you can't purchase subscriptions on a self-hosted instance.
On a self-hosted instance, the user should see the following until we have new designs:
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16919 +/- ##
==========================================
- Coverage 39.20% 39.19% -0.02%
==========================================
Files 3463 3463
Lines 98181 98188 +7
Branches 14750 14750
==========================================
- Hits 38494 38486 -8
- Misses 58024 58038 +14
- Partials 1663 1664 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…n-new-premium-page
…n-new-premium-page
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-27050
📔 Objective
The newly implemented PremiumVNextComponent does not maintain the original, Self-Hosted version of the component
In Self-Host, the PremiumComponent is supposed to show the design I put in the ticket description, but based on your code for PremiumVNextComponent , that's not included.
If we flipped the feature flag for your ticket, I don't think there would be a way for a Self-Hosted user to upload a Premium License
📸 Screenshots
Screen.Recording.2025-10-17.at.5.11.59.PM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes