PM-26201 [Defect] [Safari] Cannot unzip vault export #16909
+32
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16909 +/- ##
==========================================
+ Coverage 38.94% 39.18% +0.23%
==========================================
Files 3437 3460 +23
Lines 97511 98090 +579
Branches 14667 14736 +69
==========================================
+ Hits 37978 38437 +459
- Misses 57874 57983 +109
- Partials 1659 1670 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coroiu
reviewed
Oct 17, 2025
Comment on lines
18
to
21
| // Handle Safari download asynchronously to allow Blob conversion | ||
| // This function can't be async because the interface is not async | ||
| // eslint-disable-next-line @typescript-eslint/no-floating-promises | ||
| SafariApp.sendMessageToApp( | ||
| "downloadFile", | ||
| JSON.stringify({ | ||
| blobData: data, | ||
| blobOptions: request.blobOptions, | ||
| fileName: request.fileName, | ||
| }), | ||
| true, | ||
| ); | ||
| this.downloadSafari(request, builder); |
There was a problem hiding this comment.
suggestion: use void to be explicit about not waiting on a promise
Suggested change
| // Handle Safari download asynchronously to allow Blob conversion | |
| // This function can't be async because the interface is not async | |
| // eslint-disable-next-line @typescript-eslint/no-floating-promises | |
| SafariApp.sendMessageToApp( | |
| "downloadFile", | |
| JSON.stringify({ | |
| blobData: data, | |
| blobOptions: request.blobOptions, | |
| fileName: request.fileName, | |
| }), | |
| true, | |
| ); | |
| this.downloadSafari(request, builder); | |
| // Handle Safari download asynchronously to allow Blob conversion | |
| // This function can't be async because the interface is not async | |
| SafariApp.sendMessageToApp( | |
| "downloadFile", | |
| JSON.stringify({ | |
| blobData: data, | |
| blobOptions: request.blobOptions, | |
| fileName: request.fileName, | |
| }), | |
| true, | |
| ); | |
| void this.downloadSafari(request, builder); |
| request: FileDownloadRequest, | ||
| builder: FileDownloadBuilder, | ||
| ): Promise<void> { | ||
| let data: BlobPart = null; |
There was a problem hiding this comment.
suggestion: it seems you are explicitly converting the data to string
Suggested change
| let data: BlobPart = null; | |
| let data: string = null; |
• explicitly discard promise returned by `downloadSafari()` • confine `data` type to `string` since code all code paths assign a `string` value
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-26201?atlOrigin=eyJpIjoiZDM5NGNkNGIzNTEwNGYyMDhmYjc1NmJjNWI0OTI4Y2UiLCJwIjoiaiJ9
📔 Objective
This PR fixes a bug whereby exporting a vault as a .zip archive resulted in an empty .zip archive:
• data received as blob could not be directly converted to a base64 encoded string, and needed to be converted to a byte array first
• usage of Swift's
url.absoluteStringwas replaced withurl.path(file:///Users/username/Documents/file.txtvs/Users/username/Documents/file.txt)⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes