Skip to content

Conversation

trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Oct 16, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-23428

📔 Objective

Updates electron to v37.

This is necessary to avoid the end of support for v36, which we are currently on. Renovate created #15499, but it auto-closes because we have decided to skip it previously.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@trmartin4 trmartin4 marked this pull request as ready for review October 16, 2025 20:07
@trmartin4 trmartin4 requested a review from addisonbeck October 16, 2025 20:07
Copy link
Contributor

github-actions bot commented Oct 16, 2025

Logo
Checkmarx One – Scan Summary & Details6821a08f-f073-4cb1-8ad1-55ff4951e3ec

Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
CRITICAL CVE-2025-10890 Npm-electron-36.9.3

Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.15%. Comparing base (94cb1fe) to head (480e0f8).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16905      +/-   ##
==========================================
- Coverage   39.15%   39.15%   -0.01%     
==========================================
  Files        3456     3456              
  Lines       97972    97968       -4     
  Branches    14730    14730              
==========================================
- Hits        38364    38361       -3     
  Misses      57939    57939              
+ Partials     1669     1668       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants