-
Notifications
You must be signed in to change notification settings - Fork 1.5k
PM-26985 Use a Shadow DOM for the notification bar iframe to address FF fingerprinting issues #16903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…FF fingerprinting issues
Great job! No new security vulnerabilities introduced in this pull request |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16903 +/- ##
==========================================
+ Coverage 39.15% 39.20% +0.04%
==========================================
Files 3456 3463 +7
Lines 97959 98134 +175
Branches 14726 14736 +10
==========================================
+ Hits 38355 38470 +115
- Misses 57934 57998 +64
+ Partials 1670 1666 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-26985
📔 Objective
The objective of this PR is to place the notification bar iframe within a closed shadow root in order to help mitigate fingerprinting risks as outlined on this investigation spike here
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes