Skip to content

Conversation

dan-livefront
Copy link
Collaborator

@dan-livefront dan-livefront commented Oct 16, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26985

📔 Objective

The objective of this PR is to place the notification bar iframe within a closed shadow root in order to help mitigate fingerprinting risks as outlined on this investigation spike here

📸 Screenshots

Screenshot 2025-10-16 at 3 20 10 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@dan-livefront dan-livefront self-assigned this Oct 16, 2025
Copy link
Contributor

github-actions bot commented Oct 16, 2025

Logo
Checkmarx One – Scan Summary & Details7019a202-a851-4d28-8b2a-c61002de12b0

Great job! No new security vulnerabilities introduced in this pull request

Copy link

Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.20%. Comparing base (ba5c93f) to head (bc47788).
⚠️ Report is 13 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16903      +/-   ##
==========================================
+ Coverage   39.15%   39.20%   +0.04%     
==========================================
  Files        3456     3463       +7     
  Lines       97959    98134     +175     
  Branches    14726    14736      +10     
==========================================
+ Hits        38355    38470     +115     
- Misses      57934    57998      +64     
+ Partials     1670     1666       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bw-ghapp
Copy link
Contributor

bw-ghapp bot commented Oct 17, 2025

⚠️ Changes in this PR impact the Autofill experience of the browser client ⚠️

BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com

Caution

Unfortunately, one or more of these tests failed. 😞

Please resolve the failure before merging; reach out to @bitwarden/team-autofill-dev if you'd like help.

You can view the detailed results of the tests here.

@bw-ghapp
Copy link
Contributor

bw-ghapp bot commented Oct 17, 2025

⚠️ Changes in this PR impact the Autofill experience of the browser client ⚠️

BIT has tested the core experience with these changes and all feature flags disabled.

Caution

Unfortunately, one or more of these tests failed. 😞

Please resolve the failure before merging; reach out to @bitwarden/team-autofill-dev if you'd like help.

You can view the detailed results of the tests here.

@dan-livefront
Copy link
Collaborator Author

⚠️ Changes in this PR impact the Autofill experience of the browser client ⚠️

BIT has tested the core experience with these changes and all feature flags disabled.

Caution

Unfortunately, one or more of these tests failed. 😞

Please resolve the failure before merging; reach out to @bitwarden/team-autofill-dev if you'd like help.

You can view the detailed results of the tests here.

All tests with extension build PM-26985-use-a-shadow-dom-for-the-notification-bar-iframe-to-address-ff-fingerprinting-issues by @dan-livefront

All tests with extension build PM-26985-use-a-shadow-dom-for-the-notification-bar-iframe-to-address-ff-fingerprinting-issues by @dan-livefront

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants