Skip to content

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Oct 16, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/CL-899

📔 Objective

Enables the non tailwind eslint rule to ensure we don't accidentally add any bad classes to our browser extension.

  • Notification bar uses a custom CSS file and is excluded.
  • Removed unused UserVerificationComponent.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested review from a team as code owners October 16, 2025 17:15
Copy link

@Hinton Hinton changed the title Forbid non tailwind classes in browser [CL-899] Forbid non tailwind classes in browser Oct 16, 2025
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.16%. Comparing base (9b2fbdb) to head (11861ea).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16902   +/-   ##
=======================================
  Coverage   39.16%   39.16%           
=======================================
  Files        3456     3455    -1     
  Lines       97959    97953    -6     
  Branches    14726    14726           
=======================================
  Hits        38362    38362           
+ Misses      57927    57921    -6     
  Partials     1670     1670           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsfa107dfb-5c19-4b94-8a5b-bf861acd5b72

Great job! No new security vulnerabilities introduced in this pull request

@bw-ghapp
Copy link
Contributor

bw-ghapp bot commented Oct 16, 2025

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com.

✅ Fortunately, these BIT tests have passed! 🎉

@bw-ghapp
Copy link
Contributor

bw-ghapp bot commented Oct 16, 2025

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and all feature flags disabled.

✅ Fortunately, these BIT tests have passed! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants