Skip to content

Conversation

AlexRubik
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26352

📔 Objective

Implemented drawer functionality for "View at-risk members" and "View at-risk applications" links in the Risk Insights Activity tab, with filtering to show only critical applications and their associated members.

Files Modified

activity-card.component.ts

  • Removed: navigationLink input property and navigateToLink() method (unused)
  • Renamed: navigationTextactionText, showNavigationLinkshowActionLink
  • Renamed: navigationClickactionClick, onNavigationClick()onActionClick()

activity-card.component.html

  • Updated: Template to use new action naming (actionText, showActionLink, onActionClick)
  • Added: href="#" and $event.preventDefault() to maintain pointer cursor styling

all-activity.component.html

  • Updated: Both activity cards to use new action event binding (actionClick instead of navigationClick)
  • Updated: Input properties to use new action naming (actionText, showActionLink)

all-activity.component.ts

  • Updated: onViewAtRiskMembers() to call setDrawerForCriticalAtRiskMembers()
  • Updated: onViewAtRiskApplications() to call setDrawerForCriticalAtRiskApps()

risk-insights-data.service.ts

  • Added: setDrawerForCriticalAtRiskApps() method to filter for critical applications only
  • Added: setDrawerForCriticalAtRiskMembers() method to filter for members associated critical applications only

📸 Screenshots

image image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@AlexRubik AlexRubik self-assigned this Oct 15, 2025
@AlexRubik AlexRubik requested a review from a team as a code owner October 15, 2025 22:33
Copy link

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsa5ffc339-82b2-4140-8462-3ea6b4f15eca

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.14%. Comparing base (aa9a276) to head (d1374df).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...sk-insights/services/risk-insights-data.service.ts 0.00% 25 Missing ⚠️
...irt/access-intelligence/activity-card.component.ts 0.00% 6 Missing ⚠️
...dirt/access-intelligence/all-activity.component.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16895      +/-   ##
==========================================
+ Coverage   39.00%   39.14%   +0.14%     
==========================================
  Files        3447     3449       +2     
  Lines       97826    97945     +119     
  Branches    14708    14732      +24     
==========================================
+ Hits        38156    38341     +185     
+ Misses      58007    57934      -73     
- Partials     1663     1670       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant