[PM-26352] drawers for activity cards #16895
Open
+104
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-26352
📔 Objective
Implemented drawer functionality for "View at-risk members" and "View at-risk applications" links in the Risk Insights Activity tab, with filtering to show only critical applications and their associated members.
Files Modified
activity-card.component.ts
navigationLink
input property andnavigateToLink()
method (unused)navigationText
→actionText
,showNavigationLink
→showActionLink
navigationClick
→actionClick
,onNavigationClick()
→onActionClick()
activity-card.component.html
actionText
,showActionLink
,onActionClick
)href="#"
and$event.preventDefault()
to maintain pointer cursor stylingall-activity.component.html
actionClick
instead ofnavigationClick
)actionText
,showActionLink
)all-activity.component.ts
onViewAtRiskMembers()
to callsetDrawerForCriticalAtRiskMembers()
onViewAtRiskApplications()
to callsetDrawerForCriticalAtRiskApps()
risk-insights-data.service.ts
setDrawerForCriticalAtRiskApps()
method to filter for critical applications onlysetDrawerForCriticalAtRiskMembers()
method to filter for members associated critical applications only📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes