-
Notifications
You must be signed in to change notification settings - Fork 928
Update SDK to 2.0.0-4373-3c666766 #6311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+1
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Objective: Clean up code usage of the deprecated `InitUserCryptoMethod.Password` enumeration in preparation for its removal from the SDK. Behavioral Changes: None. This refactoring removes handling for an unsupported crypto initialization method that threw an exception or was no longer relevant. Specific Changes: - `VaultLockManagerImpl.kt`: Remove the case for `InitUserCryptoMethod.Password` in the crypto initialization logic. - `InitUserCryptoMethodExtensions.kt`: Remove the case for `InitUserCryptoMethod.Password` that previously threw an `IllegalArgumentException`.
cc14136 to
63bf5b5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6311 +/- ##
==========================================
+ Coverage 85.50% 85.51% +0.01%
==========================================
Files 763 763
Lines 54601 54620 +19
Branches 7855 7852 -3
==========================================
+ Hits 46684 46707 +23
+ Misses 5189 5187 -2
+ Partials 2728 2726 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
david-livefront
approved these changes
Jan 5, 2026
Contributor
|
Thanks @david-livefront |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app:authenticator
Bitwarden Authenticator app context
app:password-manager
Bitwarden Password Manager app context
automated-pr
PR created by workflow or other automation
t:deps
Change Type - Dependencies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Updates the SDK version from
2.0.0-4254-6c954013tocom.bitwarden:sdk-android 2.0.0-4373-3c666766What's Changed
InitUserCryptoMethod::Passwordin favour ofInitUserCryptoMethod::MasterPasswordUnlocksdk-internal#629Additional code changes:
bitwarden/sdk-internal#629 removes
InitUserCryptoMethod.Passwordso the following changes were needed:Clean up code usage of the deprecated
InitUserCryptoMethod.Passwordenumeration in preparation for its removal from the SDK.Behavioral Changes:
None. This refactoring removes handling for an unsupported crypto initialization method that threw an exception or was no longer relevant.
Specific Changes:
VaultLockManagerImpl.kt: Remove the case forInitUserCryptoMethod.Passwordin the crypto initialization logic.InitUserCryptoMethodExtensions.kt: Remove the case forInitUserCryptoMethod.Passwordthat previously threw anIllegalArgumentException.Raw changelog