Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17099] Re-Sort Quetta Browser Alphabetically #4562

Merged
merged 34 commits into from
Jan 21, 2025

Conversation

SymphonicDeviation
Copy link
Contributor

📔 Objective

Re-Sort Quetta and IronFox Browsers aphabetically

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-17099

@bitwarden-bot bitwarden-bot changed the title Re-Sort Quetta Browser Alphabetically [PM-17099] Re-Sort Quetta Browser Alphabetically Jan 15, 2025
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsf0c74c4c-871f-4634-b700-ccfe205017d3

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.36%. Comparing base (412649e) to head (1c72d45).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4562   +/-   ##
=======================================
  Coverage   88.36%   88.36%           
=======================================
  Files         603      603           
  Lines       40720    40720           
  Branches     5720     5720           
=======================================
  Hits        35983    35983           
  Misses       2747     2747           
  Partials     1990     1990           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SaintPatrck SaintPatrck added this pull request to the merge queue Jan 21, 2025
Merged via the queue into bitwarden:main with commit bb5aeaa Jan 21, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants