PM-16631 Adding coach mark container and state to allow for guided coach mark tours #4560
+1,198
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dseverns-livefront
requested review from
brian-livefront,
david-livefront,
ahaisting-livefront,
phil-livefront and
a team
as code owners
|
Great job, no security vulnerabilities found in this Pull Request |
dseverns-livefront
force-pushed
the
PM-16631-coachmark-new-login
branch
from
4f5d9b1 to
6ccf7d7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4560 +/- ##
=======================================
Coverage 88.36% 88.36%
=======================================
Files 603 603
Lines 40720 40720
Branches 5720 5720
=======================================
Hits 35983 35983
Misses 2747 2747
Partials 1990 1990 ☔ View full report in Codecov by Sentry. |
| val currentHighlightShape by state.currentHighlightShape | ||
|
|
||
| val highlightPath = | ||
| remember(boundedRectangle, currentHighlightShape) { |
There was a problem hiding this comment.
Can we move this up a line, or was this past the line limit?
| description: String, | ||
| onDismiss: (() -> Unit), | ||
| leftAction: (@Composable RowScope.() -> Unit)?, | ||
| rightAction: (@Composable RowScope.() -> Unit)?, |
There was a problem hiding this comment.
Can we add a default Modifier property here
dseverns-livefront
force-pushed
the
PM-16631-coachmark-new-login
branch
3 times, most recently
from
ee24308 to
45ccec2
Compare
dseverns-livefront
force-pushed
the
PM-16631-coachmark-new-login
branch
from
45ccec2 to
4b5f16d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-16631 [PART 1]
📔 Objective
CoachMarkContainercan highlight certain components of the UI and show a tooltip.📸 Screenshots
coachmark_example.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes