Enable bitsandbytes packaging for ROCm #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks very good! From my perspective I don't see anything amiss. @matthewdouglas could you take a second look, just to be sure and then we merge? cc @akx if you have a moment and are interested to take a look :) we always highly appreciate your opinion! |
akx
suggested changes
Jul 31, 2024
Co-authored-by: Aarni Koskela <[email protected]>
Thanks for the suggestion! HIP is a wrapper around ROCm, it supports both ROCm and CUDA platforms. The major/minor versions are same for HIP and ROCm. |
matthewdouglas
approved these changes
Jul 31, 2024
Titus-von-Koeller
requested changes
Aug 1, 2024
Co-authored-by: Titus <[email protected]>
Titus-von-Koeller
merged commit 6d9b69b
into
bitsandbytes-foundation:multi-backend-refactor
2 checks passed
|
Thanks @pnunna93 great work and thanks a lot @akx and @matthewdouglas for helping with the review 🙌🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables packaging wheels for bitsandbytes on ROCm. It updates rocm compilation and wheels build jobs to compile on ROCm 6.1 for latest Instinct and Radeon GPUs.
There are also updates to documentation based on user feedback and steps to install bitsandbytes ROCm package once available.
cc: @Titus-von-Koeller @sunway513 @amathews-amd