fix min_8bit_size ignored bug #1181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I created a new PR because I wasn't sure @Edenzzzz would be available before end of day, but I see he merged the main. Anyways, the commits and credits are yours. Closing this in favor of already merged #1286 Thanks @Edenzzzz for catching this small but significant bug, can't believe this went unnoticed for 3 years.. Really appreciate your hands-on attitude and contribution ❤️ |
|
Thanks guys for your enthusiasm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line ignores
min_8bit_sizeby setting all params with numel < 4096 to fp32, so I've removed it.cc @Titus-von-Koeller