-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add int8 ops for CPU #1178
Merged
Titus-von-Koeller
merged 13 commits into
bitsandbytes-foundation:multi-backend-refactor
from
Xia-Weiwen:multi-backend-refactor-cpu-xpu-ops
May 7, 2024
Merged
Add int8 ops for CPU #1178
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
13ad630
Add int8 ops for Intel CPU & XPU
Xia-Weiwen 77be40b
Remove XPU code; remove cpu example; add UT
Xia-Weiwen 8d0b695
Fix igemmlt correctness issue
Xia-Weiwen 67d8661
Bug fix for double_quant
Xia-Weiwen 92900f6
Remove torch.compile for double_quant
Xia-Weiwen 717245d
refine pytest.skip message
Xia-Weiwen 93e04b5
Fix lint issues
Xia-Weiwen e1b60d3
Fix backward
Xia-Weiwen 95c29a6
Fix lint issue
Xia-Weiwen b0dec0a
Update bitsandbytes/backends/cpu_xpu_common.py
Xia-Weiwen 97e41b8
Merge remote-tracking branch 'upstream/multi-backend-refactor' into m…
Xia-Weiwen 295bb97
Fix lint issue
Xia-Weiwen 37b0582
Fix lint issue
Xia-Weiwen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tensors which are already in in fp16 do not need to be set again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abhilash1910 Thanks for the comment. Here we are considering other dtypes like bfloat16 for CPU.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes correct but if tensor already in fp16 then no need to convert right? the condition only applies if bf16 or other precision applies, then it goes in the condition (logic remains same I think ). Let me know your thoughts. Looks ok eitherway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conversion is done afterwards. Here is just to print a warning.
CA, CAt, SCA, SCAt, coo_tensorA = F.double_quant(A.to(A_dtype), threshold=state.threshold)
And in fact, if tensor is already in
A_dtype
, no action will be taken.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question that might be related here. Do we need to consider any changes (e.g. fall back to fp32) for users with a CPU that does not have AVX512-BF16 or AMX? Or is that something handled by torch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will fall back to fp32 automatically. It's handled by torch.