Skip to content

[bitnami/thanos] Fix invalid YAML syntax on the query deployment template when storegateway.useEndpointGroup is false#36485

Open
TPXP wants to merge 3 commits intobitnami:mainfrom
TPXP:fix-storegateway-bad-yaml
Open

[bitnami/thanos] Fix invalid YAML syntax on the query deployment template when storegateway.useEndpointGroup is false#36485
TPXP wants to merge 3 commits intobitnami:mainfrom
TPXP:fix-storegateway-bad-yaml

Conversation

@TPXP
Copy link
Copy Markdown

@TPXP TPXP commented Mar 20, 2026

Description of the change

This fixes an issue with YAML templates for thanos query components when storegateway.useEndpointGroup is false. Since #36418, some values can be indented

- --endpoint-group={{ include "common.names.fullname" $ }}-storegateway-{{ toString $index }}.{{ $.Release.Namespace }}.svc.{{ $.Values.clusterDomain }}:{{ $.Values.storegateway.service.ports.grpc }}
  - --endpoint=dnssrv+_grpc._tcp.{{ include "common.names.fullname" $ }}-storegateway-{{ toString $index }}.{{ $.Release.Namespace }}.svc.{{ $.Values.clusterDomain }}
  - --endpoint={{ include "common.names.fullname" $ }}-storegateway-{{ toString $index }}.{{ $.Release.Namespace }}.svc.{{ $.Values.clusterDomain }}:{{ $.Values.storegateway.service.ports.grpc }}

We want the two possible lines to be at the same indentation as other arguments

- --endpoint-group={{ include "common.names.fullname" $ }}-storegateway-{{ toString $index }}.{{ $.Release.Namespace }}.svc.{{ $.Values.clusterDomain }}:{{ $.Values.storegateway.service.ports.grpc }}
- --endpoint=dnssrv+_grpc._tcp.{{ include "common.names.fullname" $ }}-storegateway-{{ toString $index }}.{{ $.Release.Namespace }}.svc.{{ $.Values.clusterDomain }}
- --endpoint={{ include "common.names.fullname" $ }}-storegateway-{{ toString $index }}.{{ $.Release.Namespace }}.svc.{{ $.Values.clusterDomain }}:{{ $.Values.storegateway.service.ports.grpc }}

Benefits

Fixes broken arguments passed to the query pod when storegateway.useEndpointGroup is false.

Possible drawbacks

Nothing I can think of

Applicable issues

Additional information

This seems like something an automated tool could have caught but I'm not sure if such tool exists.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added thanos triage Triage is needed labels Mar 20, 2026
@github-actions github-actions bot requested a review from javsalgar March 20, 2026 15:46
@TPXP TPXP force-pushed the fix-storegateway-bad-yaml branch from 2872eb9 to 62056a0 Compare March 20, 2026 15:46
…late when `storegateway.useEndpointGroup` is false

Signed-off-by: Thomas P. <TPXP@users.noreply.github.com>
@TPXP TPXP force-pushed the fix-storegateway-bad-yaml branch from 62056a0 to ce2ede3 Compare March 20, 2026 15:47
Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Mar 23, 2026
@github-actions github-actions bot removed the triage Triage is needed label Mar 23, 2026
@github-actions github-actions bot removed the request for review from javsalgar March 23, 2026 07:51
@github-actions github-actions bot requested a review from migruiz4 March 23, 2026 07:51
Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-progress thanos verify Execute verification workflow for these changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bitnami/thanos] Additional whitespaces break query deployment pods

5 participants