[bitnami/thanos] Fix invalid YAML syntax on the query deployment template when storegateway.useEndpointGroup is false#36485
Open
TPXP wants to merge 3 commits intobitnami:mainfrom
Open
[bitnami/thanos] Fix invalid YAML syntax on the query deployment template when storegateway.useEndpointGroup is false#36485TPXP wants to merge 3 commits intobitnami:mainfrom
storegateway.useEndpointGroup is false#36485TPXP wants to merge 3 commits intobitnami:mainfrom
Conversation
2872eb9 to
62056a0
Compare
…late when `storegateway.useEndpointGroup` is false Signed-off-by: Thomas P. <TPXP@users.noreply.github.com>
62056a0 to
ce2ede3
Compare
Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com>
Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This fixes an issue with YAML templates for thanos query components when
storegateway.useEndpointGroupis false. Since #36418, some values can be indentedWe want the two possible lines to be at the same indentation as other arguments
Benefits
Fixes broken arguments passed to the query pod when
storegateway.useEndpointGroupis false.Possible drawbacks
Nothing I can think of
Applicable issues
Additional information
This seems like something an automated tool could have caught but I'm not sure if such tool exists.
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm