[bitnami/redis] Allow grabbing sentinel acl configuration from userSecret

[jemand771]

Description of the change

Allow grabbing sentinel acl configuration from auth.acl.userSecret

Benefits

Sentinel acl is in sync with redis acl

Possible drawbacks

I'm not sure what the correct way of handling users without passwords would be, so I'm keeping the previous behavior of just excluding users without a password.

This may be wrong, but at least it's less wrong than before.

Applicable issues

• extends [bitnami/redis] Support retrieving Redis ACL user passwords from Kubernetes Secrets  #32434 which introduced this feature for non-sentinel acl configuration.

Additional information

test values excerpt

auth:
  acl:
    enabled: true
    sentinel: true
    users:
      - username: alice
        # password: asdasd
        commands: +@all
      - username: bob
        # password: asdasd
        commands: +@all
      - username: hasnopass
        commands: +@all
      - username: passinvalues
        password: asd
        commands: +@all
    userSecret: acl-secret

resulting `users.acl` in `configuration` configmap

user default on #c6427b12b085ca9963aa14b81f94b01c51848b0fbc065f8a2b6b5489a7a942ed ~* &* +@all
user alice on #2c26b46b68ffc68ff99b453c1d30413413422d706483bfa0f98a5e886266e7ae ~* &* +@all
user bob on #fcde2b2edba56bf408601fb721fe9b5c338d10ee429ea04fae5511b68fbf8fb9 ~* &* +@all
user hasnopass on nopass ~* &* +@all
user passinvalues on #688787d8ff144c502c7f5cffaafe2cc588d86079f9de88304c26b0cb99ce91c6 ~* &* +@all

resulting `sentinel.conf` in `configuration` configmap

dir "/tmp"
port 26379
sentinel monitor redis-prod redis-test-node-0.redis-test-headless.redis-test.svc.cluster.local 6379 2
sentinel down-after-milliseconds redis-prod 60000
sentinel failover-timeout redis-prod 180000
sentinel parallel-syncs redis-prod 1# Sentinel ACL configuration, only for users with password

user alice on #2c26b46b68ffc68ff99b453c1d30413413422d706483bfa0f98a5e886266e7ae ~* &* +@all
sentinel sentinel-user alice
sentinel sentinel-pass foo

user bob on #fcde2b2edba56bf408601fb721fe9b5c338d10ee429ea04fae5511b68fbf8fb9 ~* &* +@all
sentinel sentinel-user bob
sentinel sentinel-pass bar


user passinvalues on #688787d8ff144c502c7f5cffaafe2cc588d86079f9de88304c26b0cb99ce91c6 ~* &* +@all
sentinel sentinel-user passinvalues
sentinel sentinel-pass asd
# User-supplied sentinel configuration:
# End of sentinel configuration

ping

• @DSczyrba for hacking this together with me
• @emahdij as author of the previous PR

Checklist

• Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
• (N/A) Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
• Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
• All commits signed off and in agreement of Developer Certificate of Origin (DCO)

[jemand771]

not sure what's wrong with the tests - I can't seem to find any logs of what is actually being done other than

ginkgo action: failed » Tests: 0 passed, 0 skipped, 1 failed

[jemand771]

GitHub is being funny with suggested changes, I'll rebase/squash later

[juan131]

LGTM