Skip to content

[bitnami/prometheus] Allow tpl for ingress hostnames and allow ingress annotations to be both map object and string #33525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

KorenP1
Copy link
Contributor

@KorenP1 KorenP1 commented May 7, 2025

Allowing the tpl of ingress hostnames to match bitnami standards and allow the dynamic allocation of hostnames based on global configuration

Allowing the ingress annotations to be also type string. (Was only map object type)
This allows using string tpl in the annotations key.
Example values that is now allowed:

myGlobalMap:
  a: b
  c: d
  e: f
  
server:
  ingress:
    enabled: true
    annotations: '{{ .Values.myGlobalMap | toYaml }}'

KorenP1 added 6 commits May 7, 2025 17:12
Signed-off-by: Koren Peretz <[email protected]>
Signed-off-by: Koren Peretz <[email protected]>
Signed-off-by: Koren Peretz <[email protected]>
Signed-off-by: Koren Peretz <[email protected]>
Signed-off-by: Koren Peretz <[email protected]>
Signed-off-by: Koren Peretz <[email protected]>
@github-actions github-actions bot added prometheus triage Triage is needed labels May 7, 2025
@github-actions github-actions bot requested a review from javsalgar May 7, 2025 14:28
Signed-off-by: Bitnami Bot <[email protected]>
@KorenP1
Copy link
Contributor Author

KorenP1 commented May 8, 2025

@javsalgar @juan131

KorenP1 and others added 3 commits May 8, 2025 20:45
@javsalgar javsalgar added verify Execute verification workflow for these changes in-progress labels May 9, 2025
@github-actions github-actions bot removed the triage Triage is needed label May 9, 2025
@github-actions github-actions bot removed the request for review from javsalgar May 9, 2025 05:48
@github-actions github-actions bot requested a review from juan131 May 9, 2025 05:48
Signed-off-by: Bitnami Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress prometheus verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants