Skip to content

[bitnami/mongodb] Add ability to configure SA for backup #33112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mkuendig
Copy link

Description of the change

This MR will add the possiblity to change the ServiceAccountName in the mongoDB backup that the bitnami chart can create. We use Hashicorp vault with init containers and we need to fetch the credentials via a predefined service Account.

If the ServiceAccount is changed, it needs to pre-exist, or the job won't run. No error is thrown if the SA does not exist.

Benefits

For enterprise environments where the SA needs to be customized or an existing one that needs to be used can be used.

Possible drawbacks

None known.

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added mongodb triage Triage is needed labels Apr 22, 2025
@github-actions github-actions bot requested a review from javsalgar April 22, 2025 11:45
@mkuendig mkuendig force-pushed the fix/add_mongodb_backup_serviceaccount branch from a243007 to ebef02d Compare April 22, 2025 12:46
@javsalgar javsalgar changed the title Add ability to configure SA for backup [bitnami/mongodb] Add ability to configure SA for backup Apr 23, 2025
@javsalgar javsalgar added verify Execute verification workflow for these changes in-progress labels Apr 23, 2025
@github-actions github-actions bot removed the triage Triage is needed label Apr 23, 2025
@github-actions github-actions bot removed the request for review from javsalgar April 23, 2025 03:50
@github-actions github-actions bot requested a review from gongomgra April 23, 2025 03:50
Copy link
Contributor

@gongomgra gongomgra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Copy link
Contributor

@gongomgra gongomgra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase your branch with main and update the PR?

@mkuendig
Copy link
Author

mkuendig commented Apr 30, 2025

Can you please rebase your branch with main and update the PR?

@gongomgra Hi, I have tried to rebase this, but have now heaps of changes. I'm not sure if this is what you want. If not, I need help. I'm no dev and have a hard time to get this right with such a large repo.

@gongomgra
Copy link
Contributor

Hi @mkuendig

I think this guide would be of help. Just remember that our principal branch is named main (you need to rebase your add_mongodb_backup_serviceaccount branch with that), and that you need to push your custom branch afterwards

https://gist.github.com/ravibhure/a7e0918ff4937c9ea1c456698dcd58aa

Hope it helps!

Signed-off-by: Marco Kuendig <[email protected]>
@mkuendig mkuendig force-pushed the fix/add_mongodb_backup_serviceaccount branch from b06f170 to 8db65f4 Compare May 6, 2025 15:35
@mkuendig
Copy link
Author

mkuendig commented May 6, 2025

@gongomgra Thanks a ton for the guide. I think I could do it correctly now. Can you pls check.

Signed-off-by: Bitnami Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress mongodb verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MongoDB Chart, Backup allow ServiceAccount to be configurable
4 participants