-
Notifications
You must be signed in to change notification settings - Fork 9.5k
[bitnami/mongodb] Add ability to configure SA for backup #33112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[bitnami/mongodb] Add ability to configure SA for backup #33112
Conversation
a243007
to
ebef02d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please rebase your branch with main
and update the PR?
@gongomgra Hi, I have tried to rebase this, but have now heaps of changes. I'm not sure if this is what you want. If not, I need help. I'm no dev and have a hard time to get this right with such a large repo. |
Hi @mkuendig I think this guide would be of help. Just remember that our principal branch is named https://gist.github.com/ravibhure/a7e0918ff4937c9ea1c456698dcd58aa Hope it helps! |
Signed-off-by: Marco Kuendig <[email protected]>
b06f170
to
8db65f4
Compare
@gongomgra Thanks a ton for the guide. I think I could do it correctly now. Can you pls check. |
Signed-off-by: Bitnami Bot <[email protected]>
Description of the change
This MR will add the possiblity to change the ServiceAccountName in the mongoDB backup that the bitnami chart can create. We use Hashicorp vault with init containers and we need to fetch the credentials via a predefined service Account.
If the ServiceAccount is changed, it needs to pre-exist, or the job won't run. No error is thrown if the SA does not exist.
Benefits
For enterprise environments where the SA needs to be customized or an existing one that needs to be used can be used.
Possible drawbacks
None known.
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm