-
Notifications
You must be signed in to change notification settings - Fork 9.5k
[bitnami/keycloak] Improvements to Keycloak cache handling #32885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
01349ec
to
dbaf07c
Compare
Thank you for initiating this pull request. We appreciate your effort. This is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines. Feel free to reach out if you have any questions or need assistance with the signing process. |
dbaf07c
to
8c98584
Compare
stackName: kubernetes | ||
stackFile: "" | ||
stack: kubernetes | ||
configFile: "cache-ispn.xml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that I explicitly set the configFile here as of https://www.keycloak.org/docs/latest/release_notes/index.html#infinispan-default-xml-configuration-location
With Keycloak versions >= 26.1.0 this should not be necessary anymore, but is maybe still better to be explicitly set then implicitly assumed.
d210bfa
to
9991ffd
Compare
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Bump |
@dmaphy thanks a lot for your contribution. Could you fix the DCO following the guide provided by my colleague, please? #32885 (comment) Moreover, you are having conflicts with main branch. |
8984419
to
27a506c
Compare
Rename environment variables according to the Keycloak documentation and adjust some values to this. Signed-off-by: Dominic Hopf <[email protected]>
27a506c
to
ef54f1c
Compare
Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Alvaro Neira Ayuso <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
Rename environment variables according to the Keycloak documentation and adjust some values to this.
Description of the change
This change improves the names for the environment variables for the caching, it tries to at least partially fix #32881.
Benefits
Setting values for infinispan caches should be more clear and less leading to mis-understandings.
Possible drawbacks
When updating the chart, values for cache need to be adjusted.
Applicable issues
Additional information
Checklist
README.md
using readme-generator-for-helm