Skip to content

[bitnami/keycloak] Improvements to Keycloak cache handling #32885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dmaphy
Copy link

@dmaphy dmaphy commented Apr 9, 2025

Rename environment variables according to the Keycloak documentation and adjust some values to this.

Description of the change

This change improves the names for the environment variables for the caching, it tries to at least partially fix #32881.

Benefits

Setting values for infinispan caches should be more clear and less leading to mis-understandings.

Possible drawbacks

When updating the chart, values for cache need to be adjusted.

Applicable issues

Additional information

Checklist

@github-actions github-actions bot added keycloak triage Triage is needed labels Apr 9, 2025
@github-actions github-actions bot requested a review from carrodher April 9, 2025 09:13
@dmaphy dmaphy force-pushed the Improve_Keycloak_Cache_handling branch 3 times, most recently from 01349ec to dbaf07c Compare April 9, 2025 09:18
@carrodher
Copy link
Member

Thank you for initiating this pull request. We appreciate your effort. This is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

@dmaphy dmaphy force-pushed the Improve_Keycloak_Cache_handling branch from dbaf07c to 8c98584 Compare April 9, 2025 09:20
stackName: kubernetes
stackFile: ""
stack: kubernetes
configFile: "cache-ispn.xml"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I explicitly set the configFile here as of https://www.keycloak.org/docs/latest/release_notes/index.html#infinispan-default-xml-configuration-location

With Keycloak versions >= 26.1.0 this should not be necessary anymore, but is maybe still better to be explicitly set then implicitly assumed.

@dmaphy dmaphy force-pushed the Improve_Keycloak_Cache_handling branch from d210bfa to 9991ffd Compare April 9, 2025 13:55
Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Apr 25, 2025
@dmaphy
Copy link
Author

dmaphy commented Apr 25, 2025

Bump

@github-actions github-actions bot removed the stale 15 days without activity label Apr 26, 2025
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Apr 29, 2025
@github-actions github-actions bot removed the triage Triage is needed label Apr 29, 2025
@github-actions github-actions bot removed the request for review from carrodher April 29, 2025 07:42
@github-actions github-actions bot requested a review from alvneiayu April 29, 2025 07:42
@alvneiayu
Copy link
Contributor

@dmaphy thanks a lot for your contribution.

Could you fix the DCO following the guide provided by my colleague, please? #32885 (comment)

Moreover, you are having conflicts with main branch.

@dmaphy dmaphy force-pushed the Improve_Keycloak_Cache_handling branch from 8984419 to 27a506c Compare May 5, 2025 06:17
Rename environment variables according to the Keycloak documentation and
adjust some values to this.

Signed-off-by: Dominic Hopf <[email protected]>
@dmaphy dmaphy force-pushed the Improve_Keycloak_Cache_handling branch from 27a506c to ef54f1c Compare May 5, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress keycloak verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keycloak environment variable inconsistency in naming / Not matching the Keycloak documentation (anymore?)
4 participants