Skip to content
This repository was archived by the owner on Jun 9, 2025. It is now read-only.

Conversation

@ArnyminerZ
Copy link
Member

I don't know if there are other benefits other than having less files, and a simplier structure. Honestly, I simply think that this is the correct way to go in single-module projects.

Structure changes from:

bitfireAT/vcard4android
├ lib
│  ├ build.gradle.kts
│  └ src
│     ├ androidTest
│     ├ main
│     └ test
├ build.gradle.kts
└ settings.gradle.kts

to:

bitfireAT/vcard4android
├ src
│  ├ androidTest
│  ├ main
│  └ test
├ build.gradle.kts
└ settings.gradle.kts

So we get rid of a build.gradle.kts file, and a sub-folder level. Everything else should be the same.

Signed-off-by: Arnau Mora Gras <[email protected]>
@ArnyminerZ
Copy link
Member Author

I have just checked with DAVx⁵, and transition is transparent.

@ArnyminerZ ArnyminerZ marked this pull request as ready for review October 21, 2024 09:13
@ArnyminerZ ArnyminerZ requested a review from rfc2822 October 21, 2024 09:13
@ArnyminerZ
Copy link
Member Author

We can do the same with the other libraries if we want to

@rfc2822
Copy link
Member

rfc2822 commented Oct 21, 2024

I remember that earlier (in submodule times probably) it had this single-module structure, and then gradle played crazy and Android Studio things didn't work anymore.

I have just tried the way mentioned on https://developer.android.com/studio/projects/android-library and they say one should create a new library module in the project.

So unless this fixes some problem, I'd keep it like it is

@ArnyminerZ ArnyminerZ closed this Oct 21, 2024
@ArnyminerZ ArnyminerZ deleted the simplify-project-structure branch October 21, 2024 10:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants