Add test case for concurrent callers throwing in AsyncAtomicFactory.GetValueAsync #687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When called concurrently, AsyncAtomicFactory.GetValueAsync will enforce that one thread is calling the factory method.
Let's say
In other words, a second caller to GetValueAsync that overlaps the first should effectively queue on the same underlying task, and if the first throws, the second task should see that exception. This PR adds a test case to verify this.
By queuing on the same task like this, we mitigate lock convoys as discussed in #477.