Newsletter: add 362 (2025-07-11) #2410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitschmidty
reviewed
Jul 10, 2025
|
|
||
| - [Core Lightning #8377][] tightens [BOLT11][] invoice parsing requirements by mandating that senders not pay an invoice if a [payment secret][topic payment secrets] is missing or if a mandatory field such as p (payment hash), h (description hash), or s (secret), has an incorrect length. These changes are made to align with the recent specification updates (see Newsletters [#350][news350 bolts] and [#358][news358 bolts]). | ||
|
|
||
| - [BDK #1957][] introduces RPC batching for transaction history, Merkle proofs and block header requests to optimize full scan and sync performance with an Electrum backend. This PR also adds anchor caching to skip Simple Payment Verification (SPV) (see Newsletter [#312][news312 spv]) revalidation during a sync. Using sample data, the author observed performance improvements of 8.14 seconds to 2.59 seconds with RPC call batching on a full scan and of 1.37 seconds to 0.85 seconds with caching during a sync. |
There was a problem hiding this comment.
Suggested change
| - [BDK #1957][] introduces RPC batching for transaction history, Merkle proofs and block header requests to optimize full scan and sync performance with an Electrum backend. This PR also adds anchor caching to skip Simple Payment Verification (SPV) (see Newsletter [#312][news312 spv]) revalidation during a sync. Using sample data, the author observed performance improvements of 8.14 seconds to 2.59 seconds with RPC call batching on a full scan and of 1.37 seconds to 0.85 seconds with caching during a sync. | |
| - [BDK #1957][] introduces RPC batching for transaction history, merkle proofs and block header requests to optimize full scan and sync performance with an Electrum backend. This PR also adds anchor caching to skip Simple Payment Verification (SPV) (see Newsletter [#312][news312 spv]) revalidation during a sync. Using sample data, the author observed performance improvements of 8.14 seconds to 2.59 seconds with RPC call batching on a full scan and of 1.37 seconds to 0.85 seconds with caching during a sync. |
There was a problem hiding this comment.
I think there should be a comma between "merkle proofs" and "and" (since this is a list of 3 items).
|
I've added a summary for last month's review club. |
bitschmidty
reviewed
Jul 10, 2025
| [Improve TxOrphanage denial of service bounds][review club 31829] is a | ||
| PR by [glozow][gh glozow] that changes `TxOrphanage` eviction logic to | ||
| guarantee each peer the resources for at least 1 maximum size-package | ||
| worth of orphan resolution. These new guarantees significantly improve |
There was a problem hiding this comment.
Maybe?
Suggested change
| worth of orphan resolution. These new guarantees significantly improve | |
| worth of orphan resolutions. These new guarantees significantly improve |
There was a problem hiding this comment.
I personally prefer "resolution" but happy for someone to push the change, leaving as is for now though.
LarryRuane
reviewed
Jul 10, 2025
|
|
||
| - [Core Lightning #8377][] tightens [BOLT11][] invoice parsing requirements by mandating that senders not pay an invoice if a [payment secret][topic payment secrets] is missing or if a mandatory field such as p (payment hash), h (description hash), or s (secret), has an incorrect length. These changes are made to align with the recent specification updates (see Newsletters [#350][news350 bolts] and [#358][news358 bolts]). | ||
|
|
||
| - [BDK #1957][] introduces RPC batching for transaction history, Merkle proofs and block header requests to optimize full scan and sync performance with an Electrum backend. This PR also adds anchor caching to skip Simple Payment Verification (SPV) (see Newsletter [#312][news312 spv]) revalidation during a sync. Using sample data, the author observed performance improvements of 8.14 seconds to 2.59 seconds with RPC call batching on a full scan and of 1.37 seconds to 0.85 seconds with caching during a sync. |
There was a problem hiding this comment.
I think there should be a comma between "merkle proofs" and "and" (since this is a list of 3 items).
stickies-v
reviewed
Jul 10, 2025
There was a problem hiding this comment.
Thanks for the review club review @bitschmidty and @LarryRuane , pushed a fix commit addressing (almost) all.
| [Improve TxOrphanage denial of service bounds][review club 31829] is a | ||
| PR by [glozow][gh glozow] that changes `TxOrphanage` eviction logic to | ||
| guarantee each peer the resources for at least 1 maximum size-package | ||
| worth of orphan resolution. These new guarantees significantly improve |
There was a problem hiding this comment.
I personally prefer "resolution" but happy for someone to push the change, leaving as is for now though.
bitschmidty
reviewed
Jul 11, 2025
There was a problem hiding this comment.
ACK lede (with one fixup), topics, fixups
Thanks @harding @Gustavojfe and @stickies-v for authoring this week and @LarryRuane for the review!
| lang: en | ||
| --- | ||
| This week's newsletter briefly describes a new library allowing output | ||
| script descriptors to be compressed for use in QR codes. Also include |
There was a problem hiding this comment.
Suggested change
| script descriptors to be compressed for use in QR codes. Also include | |
| script descriptors to be compressed for use in QR codes. Also included |
bitschmidty
force-pushed
the
2025-07-11-newsletter
branch
from
9988cc3 to
c8646b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.