Require JDK 24, update GHA and GitLab CI #179
Open
+17
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msgilligan
force-pushed
the
msgilligan/gradle-require-jdk-24
branch
2 times, most recently
from
3830aad to
344d213
Compare
msgilligan
force-pushed
the
msgilligan/gradle-require-jdk-24
branch
from
344d213 to
43ee4ca
Compare
craigraw
approved these changes
May 22, 2025
gradle.properties: * set javaToolchainVersion = 24 * Remove use of the JDK23 environment variable GHA gradle.yml: * Remove javaToolchainVersion override in gradle commands .gitlab_ci.yml: * Upgrade to JDK 24. For the Trixie build we now install JDK 24 via Nix because (non-LTS) JDK 24 has been removed from Trixie. Note that `options.release` in the Gradle build files is still set to `23`, so it is currently still possible to build with JDK 23 by using `-PjavaToolchainVersion=23`, but that will change soon. `README.adoc`: Update to say JDK 24 and Gradle 8.14 are required, etc.
msgilligan
force-pushed
the
msgilligan/gradle-require-jdk-24
branch
from
43ee4ca to
adf2977
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gradle.properties:javaToolchainVersion = 24JDK23environment variableGHA
gradle.yml:javaToolchainVersionoverride in gradle commands.gitlab_ci.yml:README.adoc:Note that
options.releasein the Gradle build files is still set to23, so it is currently still possible to build with JDK 23 by using-PjavaToolchainVersion=23, but that will change soon.